third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js - Issue 2851913002: [DevTools] Do not expose agents on Target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js

Issue 2851913002: [DevTools] Do not expose agents on Target

Patch Set: storage and tests.js Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/waterfall-images.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/resource-har-headers.html » ('j') | third_party/WebKit/Source/devtools/front_end/Tests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js b/third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js

index f7f5e410d8199bbf848b5bf5a0dc32049e7a8f2f..8f5e7c98b285ebd90162e06e8d075a0f6653ae69 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/page-mock.js

@@ -7,7 +7,8 @@ function nextId(prefix) {

}

InspectorTest.connectToPage = function(targetName, pageMock, makeMainTarget) {

- var mockTarget = SDK.targetManager.createTarget(nextId('mock-target-'), targetName, pageMock.capabilities(), params => pageMock.createConnection(params));

+ var dispatcher = new Protocol.Dispatcher(params => pageMock.createConnection(params));

+ var mockTarget = SDK.targetManager.createTarget(nextId('mock-target-'), targetName, pageMock.capabilities(), dispatcher);

if (makeMainTarget) {

SDK.targetManager._targets = SDK.targetManager._targets.filter(target => target !== mockTarget);

SDK.targetManager._targets.unshift(mockTarget);