third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js - Issue 2851913002: [DevTools] Do not expose agents on Target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js

Issue 2851913002: [DevTools] Do not expose agents on Target

Patch Set: storage and tests.js Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js ('K') | « third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/Script.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js

index 83e03242de7b477bad467c794b55a51fec5ec03c..5ea49489b5ec6b170744f8b5d4581ce0894358d7 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js

@@ -8,15 +8,16 @@

SDK.ScreenCaptureModel = class extends SDK.SDKModel {

/**

* @param {!SDK.Target} target

+ * @param {!Protocol.Dispatcher} dispatcher

- constructor(target) {

- super(target);

- this._agent = target.pageAgent();

+ constructor(target, dispatcher) {

+ super(target, dispatcher);

+ this._agent = dispatcher.pageAgent();

/** @type {?function(string, !Protocol.Page.ScreencastFrameMetadata)} */

this._onScreencastFrame = null;

/** @type {?function(boolean)} */

this._onScreencastVisibilityChanged = null;

- target.registerPageDispatcher(this);

+ dispatcher.registerPageDispatcher(this);

}

/**