third_party/WebKit/Source/devtools/front_end/main/RequestAppBannerActionDelegate.js - Issue 2851913002: [DevTools] Do not expose agents on Target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/RequestAppBannerActionDelegate.js

Issue 2851913002: [DevTools] Do not expose agents on Target

Patch Set: storage and tests.js Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js ('K') | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js » ('j') | third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/main/RequestAppBannerActionDelegate.js

diff --git a/third_party/WebKit/Source/devtools/front_end/main/RequestAppBannerActionDelegate.js b/third_party/WebKit/Source/devtools/front_end/main/RequestAppBannerActionDelegate.js

index 5b2779f53b8568cb10878af78e75e0c1bd5cc45d..64299e1571c30556a29267008c7eac41b7b301e6 100644

--- a/third_party/WebKit/Source/devtools/front_end/main/RequestAppBannerActionDelegate.js

+++ b/third_party/WebKit/Source/devtools/front_end/main/RequestAppBannerActionDelegate.js

@@ -13,9 +13,9 @@ Main.RequestAppBannerActionDelegate = class {

* @return {boolean}

handleAction(context, actionId) {

- var target = SDK.targetManager.mainTarget();

- if (target && target.hasBrowserCapability()) {

- target.pageAgent().requestAppBanner();

+ var resourceTreeModel = SDK.targetManager.models(SDK.ResourceTreeModel)[0];

+ if (resourceTreeModel) {

+ resourceTreeModel.requestAppBanner();

Common.console.show();

}

return true;