Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Issue 2851913002: [DevTools] Do not expose agents on Target
Patch Set: storage and tests.js Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
index 32067513efb1d69ff7b5f484d642cfff76a1c5d2..7c0c398052c3d8e475d8ead2c8f12af02dd59fe5 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
@@ -420,6 +420,7 @@ SDK.RemoteObject = class {
SDK.RemoteObjectImpl = class extends SDK.RemoteObject {
/**
* @param {!SDK.RuntimeModel} runtimeModel
+ * @param {!Protocol.RuntimeAgent} runtimeAgent
* @param {string|undefined} objectId
* @param {string} type
* @param {string|undefined} subtype
@@ -429,11 +430,13 @@ SDK.RemoteObjectImpl = class extends SDK.RemoteObject {
* @param {!Protocol.Runtime.ObjectPreview=} preview
* @param {!Protocol.Runtime.CustomPreview=} customPreview
*/
- constructor(runtimeModel, objectId, type, subtype, value, unserializableValue, description, preview, customPreview) {
+ constructor(
+ runtimeModel, runtimeAgent, objectId, type, subtype, value, unserializableValue, description, preview,
+ customPreview) {
super();
this._runtimeModel = runtimeModel;
- this._runtimeAgent = runtimeModel.target().runtimeAgent();
+ this._runtimeAgent = runtimeAgent;
this._type = type;
this._subtype = subtype;
@@ -823,6 +826,7 @@ SDK.RemoteObjectImpl = class extends SDK.RemoteObject {
SDK.ScopeRemoteObject = class extends SDK.RemoteObjectImpl {
/**
* @param {!SDK.RuntimeModel} runtimeModel
+ * @param {!Protocol.RuntimeAgent} runtimeAgent
* @param {string|undefined} objectId
* @param {!SDK.ScopeRef} scopeRef
* @param {string} type
@@ -832,8 +836,9 @@ SDK.ScopeRemoteObject = class extends SDK.RemoteObjectImpl {
* @param {string=} description
* @param {!Protocol.Runtime.ObjectPreview=} preview
*/
- constructor(runtimeModel, objectId, scopeRef, type, subtype, value, unserializableValue, description, preview) {
- super(runtimeModel, objectId, type, subtype, value, unserializableValue, description, preview);
+ constructor(
+ runtimeModel, runtimeAgent, objectId, scopeRef, type, subtype, value, unserializableValue, description, preview) {
+ super(runtimeModel, runtimeAgent, objectId, type, subtype, value, unserializableValue, description, preview);
this._scopeRef = scopeRef;
this._savedScopeProperties = undefined;
}

Powered by Google App Engine
This is Rietveld 408576698