third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html - Issue 2851913002: [DevTools] Do not expose agents on Target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html

Issue 2851913002: [DevTools] Do not expose agents on Target

Patch Set: storage and tests.js Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/security/security-unknown-resource.html ('k') | third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters.html » ('j') | third_party/WebKit/Source/devtools/front_end/Tests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html

diff --git a/third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html b/third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html

index 239c9fb24be640b0b70bf9227d586c31efde4f2b..20a0ec5f2a69ed3a0ae04507c1c885737d920355 100644

--- a/third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html

+++ b/third_party/WebKit/LayoutTests/inspector/agents-enable-disable.html

@@ -23,15 +23,15 @@ function test()

var targets = SDK.targetManager.targets();

targets.forEach(function(target) {

- var agentNames = Object.keys(target._agents).filter(function(agentName) {

- var agent = target._agents[agentName];

+ var agentNames = Object.keys(target._dispatcher._agents).filter(function(agentName) {

+ var agent = target._dispatcher._agents[agentName];

return agent["enable"] && agent["disable"] && agentName !== "ServiceWorker" && agentName !== "Security" && agentName !== "Inspector" && agentName !== "Target"; // async wrt others.

}).sort();

function disableAgent(agentName)

{

++requestsSent;

- var agent = target._agents[agentName];

+ var agent = target._dispatcher._agents[agentName];

agent.disable(finishWhenDone.bind(null, agentName, "disable"))

.catch(finishWhenDone.bind(null, agentName, "disable"));

}

@@ -39,7 +39,7 @@ function test()

function enableAgent(agentName)

{

++requestsSent;

- var agent = target._agents[agentName];

+ var agent = target._dispatcher._agents[agentName];

agent.enable(finishWhenDone.bind(null, agentName, "enable"))

.catch(finishWhenDone.bind(null, agentName, "enable"));

}