ntp_tiles: Cleanup enum names

ntp_tiles: Cleanup enum names

- Rename "NTPTileSource" to "TileSource". ("NTP" is already in the
  folder/namespace, and is also not really accurate anyway.)
- Rename "MostVisitedTileType" to "TileVisualType", and move it out of
  metrics.h and into its own file. This makes it more accurate, and
  more consistent with TileSource.
- Update the Java packages for these from
  "org.chromium.chrome.browser.ntp" to
  "org.chromium.chrome.browser.suggestions".

BUG=703165
Review-Url: https://codereview.chromium.org/2790463003
Cr-Commit-Position: refs/heads/master@{#461756}
Committed: https://chromium.googlesource.com/chromium/src/+/231212e9d80a4868f0f1192c75e7203dbabb07f6

[Marc Treib, 2017-03-30 16:31:30]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 16:32:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-03-30 16:33:32]

treib@chromium.org changed reviewers:
+ sfiera@chromium.org

[Marc Treib, 2017-03-30 16:33:32]

For crbug.com/703165, I'll have to pass this enum through IPC. Would be nice to
fix up the name before that.

WDYT?

[Michael van Ouwerkerk, 2017-03-30 16:42:19]

On 2017/03/30 16:33:32, Marc Treib wrote:
> For crbug.com/703165, I'll have to pass this enum through IPC. Would be nice
to
> fix up the name before that.
> 
> WDYT?

With Chrome Home, we will show the tiles outside the NTP. How about "TileType"
or "TileSuggestionType"?

[sfiera, 2017-03-30 16:52:00]

LGTM

On 2017/03/30 16:42:19, Michael van Ouwerkerk wrote:
> On 2017/03/30 16:33:32, Marc Treib wrote:
> > For crbug.com/703165, I'll have to pass this enum through IPC. Would be nice
> to
> > fix up the name before that.
> > 
> > WDYT?
> 
> With Chrome Home, we will show the tiles outside the NTP. How about "TileType"
> or "TileSuggestionType"?

Moving away from "NTP tile" naming is a much bigger project, though. The
component and various other types are going to have it in their name for a while
to come.

(If you really want to, I'd go with something like TileVisualType to emphasize
that this is about how it is displayed, not where it comes from)

[commit-bot: I haz the power, 2017-03-30 17:40:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 17:40:21]

Dry run: This issue passed the CQ dry run.

[dgn, 2017-03-30 19:37:38]

I guess the backend does not care much about how things are displayed, so I
understand that this code is going to mention ntp for a long time still. But
enums generated to java end up being used in Chrome Home specific and that's a
lot more confusing then. I'd be grateful if we could at least clear the NTP
references from that.

[Marc Treib, 2017-03-31 05:58:22]

On 2017/03/30 19:37:38, dgn wrote:
> I guess the backend does not care much about how things are displayed, so I
> understand that this code is going to mention ntp for a long time still. But
> enums generated to java end up being used in Chrome Home specific and that's a
> lot more confusing then. I'd be grateful if we could at least clear the NTP
> references from that.

Hm, I'd say, as long as the whole thing is called ntp_tiles, there's not much
point trying to remove some individual NTP references. E.g. there's also the
sibling enum NTPTileSource, which also has a Java equivalent.
I guess if you insist, I could make them TileSource and TileVisualType? (With
some yet-to-be-determined package name, currently it's
"org.chromium.chrome.browser.ntp".)

[sfiera, 2017-03-31 08:21:50]

This CL is already an improvement, and changing it isn't any less work than
writing a second CL, so I see no reason not to submit it as-is. Even in Chrome
Home, I don't think "NTP tiles" is that confusing: tablet and desktop still have
an NTP and still show these tiles there.

(also, if we're going to spend time renaming things, let's rename ntp_snippets
first!)

[Marc Treib, 2017-03-31 08:28:43]

treib@chromium.org changed reviewers:
+ dgn@chromium.org, mvanouwerkerk@chromium.org

[Marc Treib, 2017-03-31 08:28:43]

Agreed - I think this is a good state for now.

+dgn,mvanouwerkerk, since you're already here: If you're okay with this, would
you mind approving the Java changes?

[Michael van Ouwerkerk, 2017-03-31 09:01:15]

https://codereview.chromium.org/2790463003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java
(right):

https://codereview.chromium.org/2790463003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java:71:
* @param tileTypes An array of values from NTPTileType indicating the type of
each
{@link NTPTileType}

https://codereview.chromium.org/2790463003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java:82:
* @param type The visual type of the item as defined in {@code NTPTileType}.
{@link NTPTileType}

https://codereview.chromium.org/2790463003/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java
(right):

https://codereview.chromium.org/2790463003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java:136: *
@return The visual type of this tile. Valid values are listed in
Can this fit on one line?

https://codereview.chromium.org/2790463003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2790463003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:42311: <owner>newt@chromium.org</owner>
Is newt still the correct owner for this histogram? He left the project some
time ago. There are more histograms like this, maybe updating the owners is
something for a followup CL.

[Michael van Ouwerkerk, 2017-03-31 09:02:08]

On 2017/03/31 08:28:43, Marc Treib wrote:
> Agreed - I think this is a good state for now.
> 
> +dgn,mvanouwerkerk, since you're already here: If you're okay with this, would
> you mind approving the Java changes?

I would prefer TileSource and TileVisualType. Apart from the NTP vs Chrome Home
concern, there's currently a lot of repetition  like
"ntp.NTPTileType.NTPTileTypeEnum". Renaming things twice in a row seems like
extra churn in our code, affecting blame stats and possibly creating merge
conflicts (also when fixing things on a release branch). But, if you really
don't want to do the additional renamings now, this CL is an improvement so
lgtm.

[dgn, 2017-03-31 09:41:51]

Didn't mean to rename everything, just the Java side. We have modifiers for
that, the one that would be relevant here would be
GENERATED_JAVA_CLASS_NAME_OVERRIDE (e.g.
https://cs.chromium.org/chromium/src/chrome/browser/android/shortcut_info.h?t...)

Another reason against the current name is that the style guide would require
the correct casing to be NtpTileType anyway.

[dgn, 2017-03-31 09:51:56]

On 2017/03/31 09:41:51, dgn wrote:
> Didn't mean to rename everything, just the Java side. We have modifiers for
> that, the one that would be relevant here would be
> GENERATED_JAVA_CLASS_NAME_OVERRIDE (e.g.
>
https://cs.chromium.org/chromium/src/chrome/browser/android/shortcut_info.h?t...)
> 
> Another reason against the current name is that the style guide would require
> the correct casing to be NtpTileType anyway.

Besides that, lgtm :) I also just filed https://crbug.com/707186 to get rid of
the nested annotation names. Will have a look at that next week or after BP

[Marc Treib, 2017-04-03 09:31:03]

On 2017/03/31 09:51:56, dgn wrote:
> On 2017/03/31 09:41:51, dgn wrote:
> > Didn't mean to rename everything, just the Java side. We have modifiers for
> > that, the one that would be relevant here would be
> > GENERATED_JAVA_CLASS_NAME_OVERRIDE (e.g.
> >
>
https://cs.chromium.org/chromium/src/chrome/browser/android/shortcut_info.h?t...)
> > 
> > Another reason against the current name is that the style guide would
require
> > the correct casing to be NtpTileType anyway.
> 
> Besides that, lgtm :) I also just filed https://crbug.com/707186 to get rid of
> the nested annotation names. Will have a look at that next week or after BP

Hm, I think there's value in having the names be consistent between Java and
C++. Rather than introducing name mangling, I'll just rename everything now.

@sfiera as ntp_tiles owner: Any objections to TileSource and TileVisualType?
Should I also move TileVisualType out of the metrics header (and namespace) into
its own file, alongside TileType?

[sfiera, 2017-04-03 09:47:17]

On 2017/04/03 09:31:03, Marc Treib wrote:
> On 2017/03/31 09:51:56, dgn wrote:
> > On 2017/03/31 09:41:51, dgn wrote:
> > > Didn't mean to rename everything, just the Java side. We have modifiers
for
> > > that, the one that would be relevant here would be
> > > GENERATED_JAVA_CLASS_NAME_OVERRIDE (e.g.
> > >
> >
>
https://cs.chromium.org/chromium/src/chrome/browser/android/shortcut_info.h?t...)
> > > 
> > > Another reason against the current name is that the style guide would
> require
> > > the correct casing to be NtpTileType anyway.
> > 
> > Besides that, lgtm :) I also just filed https://crbug.com/707186 to get rid
of
> > the nested annotation names. Will have a look at that next week or after BP
> 
> Hm, I think there's value in having the names be consistent between Java and
> C++. Rather than introducing name mangling, I'll just rename everything now.
> 
> @sfiera as ntp_tiles owner: Any objections to TileSource and TileVisualType?
> Should I also move TileVisualType out of the metrics header (and namespace)
into
> its own file, alongside TileType?

Any of that is fine by me.

[Marc Treib, 2017-04-03 13:21:14]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 13:21:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-04-03 13:23:09]

Alright, all done (assuming the bots are happy). This got rather larger than
expected...

PTAL - either mvanouwerkerk or dgn for java, and sfiera for the rest.

https://codereview.chromium.org/2790463003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java
(right):

https://codereview.chromium.org/2790463003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java:71:
* @param tileTypes An array of values from NTPTileType indicating the type of
each
On 2017/03/31 09:01:15, Michael van Ouwerkerk wrote:
> {@link NTPTileType}

Done.

https://codereview.chromium.org/2790463003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java:82:
* @param type The visual type of the item as defined in {@code NTPTileType}.
On 2017/03/31 09:01:15, Michael van Ouwerkerk wrote:
> {@link NTPTileType}

Done.

https://codereview.chromium.org/2790463003/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java
(right):

https://codereview.chromium.org/2790463003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java:136: *
@return The visual type of this tile. Valid values are listed in
On 2017/03/31 09:01:15, Michael van Ouwerkerk wrote:
> Can this fit on one line?

Yep, done.

https://codereview.chromium.org/2790463003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2790463003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:42311: <owner>newt@chromium.org</owner>
On 2017/03/31 09:01:15, Michael van Ouwerkerk wrote:
> Is newt still the correct owner for this histogram? He left the project some
> time ago. There are more histograms like this, maybe updating the owners is
> something for a followup CL.

Good point. Yup, I'll do that in a followup.

[Michael van Ouwerkerk, 2017-04-03 13:24:53]

I'll take a look. Please update the CL description :-)

[Michael van Ouwerkerk, 2017-04-03 13:36:00]

lgtm

https://codereview.chromium.org/2790463003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java
(right):

https://codereview.chromium.org/2790463003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java:83:
void recordOpenedMostVisitedItem(int index, @TileVisualType.TileVisualTypeEnum
int type,
Cool, and this will be further simplified to @TileVisualType once Nicolas's CL
lands: https://codereview.chromium.org/2792583002/

[Michael van Ouwerkerk, 2017-04-03 13:36:13]

And thanks!

[sfiera, 2017-04-03 13:38:10]

LGTM with some very optional suggestions

https://codereview.chromium.org/2790463003/diff/60001/components/ntp_tiles/ti...
File components/ntp_tiles/tile_source.h (right):

https://codereview.chromium.org/2790463003/diff/60001/components/ntp_tiles/ti...
components/ntp_tiles/tile_source.h:15: TOP_SITES,
You know, we've talked about renaming these to CLIENT, SERVER… ;)

https://codereview.chromium.org/2790463003/diff/60001/components/ntp_tiles/ti...
File components/ntp_tiles/tile_visual_type.h (right):

https://codereview.chromium.org/2790463003/diff/60001/components/ntp_tiles/ti...
components/ntp_tiles/tile_visual_type.h:17: enum TileVisualType {
Now that this is in the ntp_tiles namespace, shouldn't it be an enum class?

https://codereview.chromium.org/2790463003/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2790463003/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:42377: +<histogram
name="NewTabPage.TileType" enum="NTPTileVisualType">
Is it possible to name this more like its C++ name, e.g.
ntp_tiles::TileVisualType or ntp_tiles.TileVisualType (or even
NTPTiles_TileVisualType)?

[Marc Treib, 2017-04-03 13:41:18]

Description was changed from

==========
ntp_tiles: Rename MostVisitedTileType to NTPTileType

This is consistent with how everything else is named, in particular
NTPTileSource.

BUG=703165
==========

to

==========
ntp_tiles: Cleanup enum names

- Rename "NTPTileSource" to "TileSource". ("NTP" is already in the
  folder/namespace, and is also not really accurate anyway.)
- Rename "MostVisitedTileType" to "TileVisualType", and move it out of
  metrics.h and into its own file. This makes it more accurate, and
  more consistent with TileSource.
- Update the Java packages for these from
  "org.chromium.chrome.browser.ntp" to
  "org.chromium.chrome.browser.suggestions".

BUG=703165
==========

[Marc Treib, 2017-04-03 13:52:01]

Thanks!
Since this CL is already way too large (and I've spent too much time yak shaving
here), I've postponed all the optional things to potential future follow-ups :)

I'll add other owners now.

https://codereview.chromium.org/2790463003/diff/60001/components/ntp_tiles/ti...
File components/ntp_tiles/tile_source.h (right):

https://codereview.chromium.org/2790463003/diff/60001/components/ntp_tiles/ti...
components/ntp_tiles/tile_source.h:15: TOP_SITES,
On 2017/04/03 13:38:10, sfiera wrote:
> You know, we've talked about renaming these to CLIENT, SERVER… ;)

Yup, but this CL is already way too large. Follow-up?

https://codereview.chromium.org/2790463003/diff/60001/components/ntp_tiles/ti...
File components/ntp_tiles/tile_visual_type.h (right):

https://codereview.chromium.org/2790463003/diff/60001/components/ntp_tiles/ti...
components/ntp_tiles/tile_visual_type.h:17: enum TileVisualType {
On 2017/04/03 13:38:10, sfiera wrote:
> Now that this is in the ntp_tiles namespace, shouldn't it be an enum class?

I thought about it, but the UMA_HISTOGRAM macros don't work well (or at all?)
with enum classes.

https://codereview.chromium.org/2790463003/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2790463003/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:42377: +<histogram
name="NewTabPage.TileType" enum="NTPTileVisualType">
On 2017/04/03 13:38:10, sfiera wrote:
> Is it possible to name this more like its C++ name, e.g.
> ntp_tiles::TileVisualType or ntp_tiles.TileVisualType (or even
> NTPTiles_TileVisualType)?

I don't think "." or "::" are allowed in the name. "_" should work I guess,
though I couldn't immediately find an example of an enum name with an
underscore. But IMO it's fine if the histograms.xml enum doesn't have to exact
same name as the C++ one.

[commit-bot: I haz the power, 2017-04-03 13:53:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 13:53:39]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[sfiera, 2017-04-03 13:59:31]

On 2017/04/03 13:52:01, Marc Treib wrote:
> Thanks!
> Since this CL is already way too large (and I've spent too much time yak
shaving
> here), I've postponed all the optional things to potential future follow-ups
:)

Yep, makes sense.

[Marc Treib, 2017-04-03 14:01:54]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 14:02:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-04-03 14:03:24]

treib@chromium.org changed reviewers:
+ isherman@chromium.org

[Marc Treib, 2017-04-03 14:03:25]

+isherman for histograms.xml. PTAL!

https://codereview.chromium.org/2790463003/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2790463003/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:102899: -  <int value="4"
label="ThumbnailLocal">
I know that we usually don't remove enum entries, but these have never been
recorded, and they don't exist in the C++ equivalent of this enum. I don't know
why they even exist.

[Marc Treib, 2017-04-03 14:10:00]

treib@chromium.org changed reviewers:
+ justincohen@chromium.org, rsesek@chromium.org

[Marc Treib, 2017-04-03 14:10:01]

+justincohen for ios/

+rsesek for IPC, more specifically: instant.mojom, instant.typemap,
instant_struct_traits.h, and render_messages.h

PTAL! It's all just trivial renaming.

[justincohen, 2017-04-03 14:55:55]

ios lgtm

[commit-bot: I haz the power, 2017-04-03 15:22:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 15:22:24]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2017-04-03 17:47:15]

mojom LGTM

[Ilya Sherman, 2017-04-03 21:34:55]

https://codereview.chromium.org/2790463003/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2790463003/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:102899: -  <int value="4"
label="ThumbnailLocal">
On 2017/04/03 14:03:25, Marc Treib wrote:
> I know that we usually don't remove enum entries, but these have never been
> recorded, and they don't exist in the C++ equivalent of this enum. I don't
know
> why they even exist.

Are you sure they have never been recorded?  Unless you can track down exactly
when these were added and confirm that they're never been used, I'd prefer to
play it safe and keep the entries, perhaps marking them as " (deprecated)" in
the labels.

[Marc Treib, 2017-04-04 08:09:21]

isherman, please take a look again!

https://codereview.chromium.org/2790463003/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2790463003/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:102899: -  <int value="4"
label="ThumbnailLocal">
On 2017/04/03 21:34:55, Ilya Sherman wrote:
> On 2017/04/03 14:03:25, Marc Treib wrote:
> > I know that we usually don't remove enum entries, but these have never been
> > recorded, and they don't exist in the C++ equivalent of this enum. I don't
> know
> > why they even exist.
> 
> Are you sure they have never been recorded?  Unless you can track down exactly
> when these were added and confirm that they're never been used, I'd prefer to
> play it safe and keep the entries, perhaps marking them as " (deprecated)" in
> the labels.

Good call! Turns out I was wrong, and they were actually recorded
(https://codereview.chromium.org/1373983003).
I've marked them deprecated, and also added them (commented-out) on the C++
side.

[Marc Treib, 2017-04-04 08:09:35]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 08:09:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 10:22:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 10:22:06]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Marc Treib, 2017-04-04 11:01:07]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 11:01:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 11:58:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 11:58:21]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2017-04-04 16:31:38]

histograms.xml lgtm, thanks.

[Marc Treib, 2017-04-04 16:55:55]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2017-04-04 16:55:55]

The patchset sent to the CQ was uploaded after l-g-t-m from dgn@chromium.org,
mvanouwerkerk@chromium.org, sfiera@chromium.org, justincohen@chromium.org,
rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2790463003/#ps100001
(title: "add back histogram enums")

[commit-bot: I haz the power, 2017-04-04 16:56:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 17:09:29]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491324955056280,
"parent_rev": "f88e1c7fcb7e4ea137e9c62a1ebbe76182bdc5f3", "commit_rev":
"231212e9d80a4868f0f1192c75e7203dbabb07f6"}

[commit-bot: I haz the power, 2017-04-04 17:10:20]

Description was changed from

==========
ntp_tiles: Cleanup enum names

- Rename "NTPTileSource" to "TileSource". ("NTP" is already in the
  folder/namespace, and is also not really accurate anyway.)
- Rename "MostVisitedTileType" to "TileVisualType", and move it out of
  metrics.h and into its own file. This makes it more accurate, and
  more consistent with TileSource.
- Update the Java packages for these from
  "org.chromium.chrome.browser.ntp" to
  "org.chromium.chrome.browser.suggestions".

BUG=703165
==========

to

==========
ntp_tiles: Cleanup enum names

- Rename "NTPTileSource" to "TileSource". ("NTP" is already in the
  folder/namespace, and is also not really accurate anyway.)
- Rename "MostVisitedTileType" to "TileVisualType", and move it out of
  metrics.h and into its own file. This makes it more accurate, and
  more consistent with TileSource.
- Update the Java packages for these from
  "org.chromium.chrome.browser.ntp" to
  "org.chromium.chrome.browser.suggestions".

BUG=703165

Review-Url: https://codereview.chromium.org/2790463003
Cr-Commit-Position: refs/heads/master@{#461756}
Committed:
https://chromium.googlesource.com/chromium/src/+/231212e9d80a4868f0f1192c75e7...
==========

[commit-bot: I haz the power, 2017-04-04 17:10:22]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/231212e9d80a4868f0f1192c75e7...