Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: chrome/common/instant.mojom

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)
Patch Set: add back histogram enums Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/ntp_tiles_internals_ui.cc ('k') | chrome/common/instant.typemap » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module chrome.mojom; 5 module chrome.mojom;
6 6
7 import "mojo/common/string16.mojom"; 7 import "mojo/common/string16.mojom";
8 import "mojo/common/time.mojom"; 8 import "mojo/common/time.mojom";
9 import "url/mojo/url.mojom"; 9 import "url/mojo/url.mojom";
10 10
11 [Native] 11 [Native]
12 enum NTPLoggingEventType; 12 enum NTPLoggingEventType;
13 13
14 [Native] 14 [Native]
15 enum OmniboxFocusState; 15 enum OmniboxFocusState;
16 16
17 [Native] 17 [Native]
18 enum NTPTileSource; 18 enum TileSource;
19 19
20 // Interface used to connect to the embedded search interface. This is a 20 // Interface used to connect to the embedded search interface. This is a
21 // separate interface such that a reverse connection (|client| below) can be 21 // separate interface such that a reverse connection (|client| below) can be
22 // passed when connecting. 22 // passed when connecting.
23 interface EmbeddedSearchConnector { 23 interface EmbeddedSearchConnector {
24 // Connect to the interface. |instant| is the connection which the client will 24 // Connect to the interface. |instant| is the connection which the client will
25 // use to query the embedded search interface. |client| is the connection used 25 // use to query the embedded search interface. |client| is the connection used
26 // by the embedded search interface implementation to push browser state 26 // by the embedded search interface implementation to push browser state
27 // updates to the client. 27 // updates to the client.
28 Connect(associated Instant& instant, associated SearchBox client); 28 Connect(associated Instant& instant, associated SearchBox client);
(...skipping 21 matching lines...) Expand all
50 UndoMostVisitedDeletion(int32 page_seq_no, url.mojom.Url url); 50 UndoMostVisitedDeletion(int32 page_seq_no, url.mojom.Url url);
51 51
52 // Logs events from InstantExtended New Tab Pages. 52 // Logs events from InstantExtended New Tab Pages.
53 LogEvent(int32 page_seq_no, 53 LogEvent(int32 page_seq_no,
54 NTPLoggingEventType event, 54 NTPLoggingEventType event,
55 mojo.common.mojom.TimeDelta time); 55 mojo.common.mojom.TimeDelta time);
56 56
57 // Logs an impression on one of the Most Visited tile on the InstantExtended 57 // Logs an impression on one of the Most Visited tile on the InstantExtended
58 // New Tab Page. 58 // New Tab Page.
59 LogMostVisitedImpression(int32 page_seq_no, int32 position, 59 LogMostVisitedImpression(int32 page_seq_no, int32 position,
60 NTPTileSource tile_source); 60 TileSource tile_source);
61 61
62 // Logs a navigation on one of the Most Visited tile on the InstantExtended 62 // Logs a navigation on one of the Most Visited tile on the InstantExtended
63 // New Tab Page. 63 // New Tab Page.
64 LogMostVisitedNavigation(int32 page_seq_no, int32 position, 64 LogMostVisitedNavigation(int32 page_seq_no, int32 position,
65 NTPTileSource tile_source); 65 TileSource tile_source);
66 66
67 // Tells InstantExtended to paste text into the omnibox. If text is empty, 67 // Tells InstantExtended to paste text into the omnibox. If text is empty,
68 // the clipboard contents will be pasted. This causes the omnibox dropdown to 68 // the clipboard contents will be pasted. This causes the omnibox dropdown to
69 // open. 69 // open.
70 PasteAndOpenDropdown(int32 page_seq_no, 70 PasteAndOpenDropdown(int32 page_seq_no,
71 mojo.common.mojom.String16 text_to_be_pasted); 71 mojo.common.mojom.String16 text_to_be_pasted);
72 72
73 // The Instant page asks whether the user syncs its history. 73 // The Instant page asks whether the user syncs its history.
74 HistorySyncCheck(int32 page_seq_no); 74 HistorySyncCheck(int32 page_seq_no);
75 75
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 115
116 ThemeChanged(ThemeBackgroundInfo value); 116 ThemeChanged(ThemeBackgroundInfo value);
117 117
118 // TODO(treib): Remove the *Result methods and instead add return values to 118 // TODO(treib): Remove the *Result methods and instead add return values to
119 // the correspnding methods in the Instant interface above. 119 // the correspnding methods in the Instant interface above.
120 HistorySyncCheckResult(bool sync_history); 120 HistorySyncCheckResult(bool sync_history);
121 121
122 ChromeIdentityCheckResult(mojo.common.mojom.String16 identity, 122 ChromeIdentityCheckResult(mojo.common.mojom.String16 identity,
123 bool identity_match); 123 bool identity_match);
124 }; 124 };
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/ntp_tiles_internals_ui.cc ('k') | chrome/common/instant.typemap » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698