Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: ios/chrome/browser/ui/ntp/google_landing_controller.mm

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)
Patch Set: add back histogram enums Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/ntp/google_landing_controller.mm
diff --git a/ios/chrome/browser/ui/ntp/google_landing_controller.mm b/ios/chrome/browser/ui/ntp/google_landing_controller.mm
index 36cd18c11fe74726da39208dc55fb9a0580aaef1..b9f99f167d93e3d3e5042a7bbf04485a9d84d7e5 100644
--- a/ios/chrome/browser/ui/ntp/google_landing_controller.mm
+++ b/ios/chrome/browser/ui/ntp/google_landing_controller.mm
@@ -314,7 +314,7 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
- (void)reloadData;
// Logs a histogram due to a Most Visited item being opened.
- (void)logMostVisitedClick:(const NSUInteger)visitedIndex
- tileType:(ntp_tiles::metrics::MostVisitedTileType)tileType;
+ tileType:(ntp_tiles::TileVisualType)tileType;
// Returns the size of |_mostVisitedData|.
- (NSUInteger)numberOfItems;
// Returns the number of non empty tiles (as opposed to the placeholder tiles).
@@ -1053,7 +1053,7 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
}
- (void)logMostVisitedClick:(const NSUInteger)visitedIndex
- tileType:(ntp_tiles::metrics::MostVisitedTileType)tileType {
+ tileType:(ntp_tiles::TileVisualType)tileType {
new_tab_page_uma::RecordAction(
_browserState, new_tab_page_uma::ACTION_OPENED_MOST_VISITED_ENTRY);
base::RecordAction(UserMetricsAction("MobileNTPMostVisited"));
@@ -1108,7 +1108,7 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
_recordedPageImpression = YES;
std::vector<ntp_tiles::metrics::TileImpression> tiles;
for (const ntp_tiles::NTPTile& ntpTile : data) {
- tiles.emplace_back(ntpTile.source, ntp_tiles::metrics::UNKNOWN_TILE_TYPE,
+ tiles.emplace_back(ntpTile.source, ntp_tiles::UNKNOWN_TILE_TYPE,
ntpTile.url);
}
ntp_tiles::metrics::RecordPageImpression(
« no previous file with comments | « components/ntp_tiles/webui/ntp_tiles_internals_message_handler_client.h ('k') | ios/chrome/browser/ui/ntp/most_visited_cell.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698