Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: ios/chrome/browser/ui/ntp/most_visited_cell.mm

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)
Patch Set: add back histogram enums Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/ntp/most_visited_cell.mm
diff --git a/ios/chrome/browser/ui/ntp/most_visited_cell.mm b/ios/chrome/browser/ui/ntp/most_visited_cell.mm
index 21e5a017f589ac181fe5fd2696697d23b53384c8..df2b223aba914e74ed4a95e3d7d4a921a0b0f5be 100644
--- a/ios/chrome/browser/ui/ntp/most_visited_cell.mm
+++ b/ios/chrome/browser/ui/ntp/most_visited_cell.mm
@@ -46,7 +46,7 @@ const CGFloat kMaximumHeight = 100;
// Weak reference to the relevant BrowserState.
ios::ChromeBrowserState* _browserState;
// Backs property with the same name.
- ntp_tiles::metrics::MostVisitedTileType _tileType;
+ ntp_tiles::TileVisualType _tileType;
base::scoped_nsobject<UILabel> _label;
base::scoped_nsobject<UILabel> _noIconLabel;
@@ -150,7 +150,7 @@ const CGFloat kMaximumHeight = 100;
title:(NSString*)title
browserState:(ios::ChromeBrowserState*)browserState {
_browserState = browserState;
- _tileType = ntp_tiles::metrics::NONE;
+ _tileType = ntp_tiles::TileVisualType::NONE;
[self setText:title];
[self setURL:URL];
base::WeakNSObject<MostVisitedCell> weakSelf(self);
@@ -228,15 +228,15 @@ const CGFloat kMaximumHeight = 100;
setText:base::SysUTF16ToNSString(favicon::GetFallbackIconText(_URL))];
[_noIconLabel setTextColor:textColor];
[_imageView setBackgroundColor:backgroundColor];
- _tileType = isDefaultBackgroundColor ? ntp_tiles::metrics::ICON_DEFAULT
- : ntp_tiles::metrics::ICON_COLOR;
+ _tileType = isDefaultBackgroundColor ? ntp_tiles::TileVisualType::ICON_DEFAULT
+ : ntp_tiles::TileVisualType::ICON_COLOR;
}
- (void)setImage:(UIImage*)image {
[_imageView setBackgroundColor:nil];
[_noIconLabel setText:nil];
[_imageView setImage:image];
- _tileType = ntp_tiles::metrics::ICON_REAL;
+ _tileType = ntp_tiles::TileVisualType::ICON_REAL;
}
@end
« no previous file with comments | « ios/chrome/browser/ui/ntp/most_visited_cell.h ('k') | ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698