Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)
Patch Set: add back histogram enums Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
index e9376679da830da763f27cdf8f3429783bf6f0c3..3ca9c8412b0fbd488a6e9191c96044298d022384 100644
--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
@@ -98,7 +98,7 @@ void NTPUserDataLogger::LogEvent(NTPLoggingEventType event,
void NTPUserDataLogger::LogMostVisitedImpression(
int position,
- ntp_tiles::NTPTileSource tile_source) {
+ ntp_tiles::TileSource tile_source) {
if ((position >= kNumMostVisited) || impression_was_logged_[position]) {
return;
}
@@ -108,9 +108,9 @@ void NTPUserDataLogger::LogMostVisitedImpression(
void NTPUserDataLogger::LogMostVisitedNavigation(
int position,
- ntp_tiles::NTPTileSource tile_source) {
+ ntp_tiles::TileSource tile_source) {
ntp_tiles::metrics::RecordTileClick(position, tile_source,
- ntp_tiles::metrics::THUMBNAIL);
+ ntp_tiles::TileVisualType::THUMBNAIL);
// Records the action. This will be available as a time-stamped stream
// server-side and can be used to compute time-to-long-dwell.
@@ -163,13 +163,13 @@ void NTPUserDataLogger::EmitNtpStatistics(base::TimeDelta load_time) {
break;
}
if (impression_tile_source_[i] ==
- ntp_tiles::NTPTileSource::SUGGESTIONS_SERVICE) {
+ ntp_tiles::TileSource::SUGGESTIONS_SERVICE) {
has_server_side_suggestions = true;
}
// No URL passed since we're not interested in favicon-related Rappor
// metrics.
tiles.emplace_back(impression_tile_source_[i],
- ntp_tiles::metrics::THUMBNAIL, GURL());
+ ntp_tiles::TileVisualType::THUMBNAIL, GURL());
}
// Not interested in Rappor metrics.
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.h ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698