Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/MostVisitedSites.java

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.suggestions; 5 package org.chromium.chrome.browser.suggestions;
6 6
7 import org.chromium.base.annotations.CalledByNative; 7 import org.chromium.base.annotations.CalledByNative;
8 import org.chromium.chrome.browser.ntp.MostVisitedTileType;
9 import org.chromium.chrome.browser.ntp.NTPTileSource; 8 import org.chromium.chrome.browser.ntp.NTPTileSource;
9 import org.chromium.chrome.browser.ntp.NTPTileType;
10 10
11 /** 11 /**
12 * Methods to provide most recent urls, titles and thumbnails. 12 * Methods to provide most recent urls, titles and thumbnails.
13 */ 13 */
14 interface MostVisitedSites { 14 interface MostVisitedSites {
15 /** 15 /**
16 * An interface for handling events in {@link MostVisitedSites}. 16 * An interface for handling events in {@link MostVisitedSites}.
17 */ 17 */
18 interface Observer { 18 interface Observer {
19 /** 19 /**
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 void addBlacklistedUrl(String url); 61 void addBlacklistedUrl(String url);
62 62
63 /** 63 /**
64 * Removes a URL from the most visited URLs blacklist. 64 * Removes a URL from the most visited URLs blacklist.
65 */ 65 */
66 void removeBlacklistedUrl(String url); 66 void removeBlacklistedUrl(String url);
67 67
68 /** 68 /**
69 * Records metrics about an impression, including the sources (local, server , ...) and visual 69 * Records metrics about an impression, including the sources (local, server , ...) and visual
70 * types of the tiles that are shown. 70 * types of the tiles that are shown.
71 * @param tileTypes An array of values from MostVisitedTileType indicating t he type of each 71 * @param tileTypes An array of values from NTPTileType indicating the type of each
Michael van Ouwerkerk 2017/03/31 09:01:15 {@link NTPTileType}
Marc Treib 2017/04/03 13:23:09 Done.
72 * tile that's currently showing. 72 * tile that's currently showing.
73 * @param sources An array of values from NTPTileSource indicating the sourc e of each tile 73 * @param sources An array of values from NTPTileSource indicating the sourc e of each tile
74 * that's currently showing. 74 * that's currently showing.
75 * @param tileUrls An array of strings indicating the URL of each tile. 75 * @param tileUrls An array of strings indicating the URL of each tile.
76 */ 76 */
77 void recordPageImpression(int[] tileTypes, int[] sources, String[] tileUrls) ; 77 void recordPageImpression(int[] tileTypes, int[] sources, String[] tileUrls) ;
78 78
79 /** 79 /**
80 * Records the opening of a Most Visited Item. 80 * Records the opening of a Most Visited Item.
81 * @param index The index of the item that was opened. 81 * @param index The index of the item that was opened.
82 * @param type The visual type of the item as defined in {@code MostVisitedT ileType}. 82 * @param type The visual type of the item as defined in {@code NTPTileType} .
Michael van Ouwerkerk 2017/03/31 09:01:15 {@link NTPTileType}
Marc Treib 2017/04/03 13:23:09 Done.
83 * @param source The {@code NTPTileSource} that generated this item. 83 * @param source The {@code NTPTileSource} that generated this item.
84 */ 84 */
85 void recordOpenedMostVisitedItem(int index, 85 void recordOpenedMostVisitedItem(int index, @NTPTileType.NTPTileTypeEnum int type,
86 @MostVisitedTileType.MostVisitedTileTypeEnum int type,
87 @NTPTileSource.NTPTileSourceEnum int source); 86 @NTPTileSource.NTPTileSourceEnum int source);
88 } 87 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698