chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java - Issue 2790463003: ntp_tiles: Cleanup enum names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)

Patch Set: add back histogram enums Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java

index 2efbda108a142125cf639545b85b6e9669ef39f1..2918a5fc8ae05a79843bdf31051a88e8be695e12 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java

@@ -30,7 +30,6 @@ import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.favicon.LargeIconBridge.LargeIconCallback;

import org.chromium.chrome.browser.ntp.ContextMenuManager;

import org.chromium.chrome.browser.ntp.ContextMenuManager.ContextMenuItemId;

-import org.chromium.chrome.browser.ntp.MostVisitedTileType;

import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

import org.chromium.chrome.browser.widget.RoundedIconGenerator;

import org.chromium.ui.mojom.WindowOpenDisposition;

@@ -408,8 +407,8 @@ public class TileGroup implements MostVisitedSites.Observer {

mIconGenerator.setBackgroundColor(fallbackColor);

icon = mIconGenerator.generateIconForUrl(mUrl);

tile.setIcon(new BitmapDrawable(mContext.getResources(), icon));

- tile.setType(isFallbackColorDefault ? MostVisitedTileType.ICON_DEFAULT

- : MostVisitedTileType.ICON_COLOR);

+ tile.setType(isFallbackColorDefault ? TileVisualType.ICON_DEFAULT

+ : TileVisualType.ICON_COLOR);

} else {

RoundedBitmapDrawable roundedIcon =

RoundedBitmapDrawableFactory.create(mContext.getResources(), icon);

@@ -421,7 +420,7 @@ public class TileGroup implements MostVisitedSites.Observer {

roundedIcon.setFilterBitmap(true);

tile.setIcon(roundedIcon);

- tile.setType(MostVisitedTileType.ICON_REAL);

+ tile.setType(TileVisualType.ICON_REAL);

}

mObserver.onTileIconChanged(tile);