Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/android/ntp/most_visited_sites_bridge.cc

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)
Patch Set: add back histogram enums Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/ntp/most_visited_sites_bridge.cc
diff --git a/chrome/browser/android/ntp/most_visited_sites_bridge.cc b/chrome/browser/android/ntp/most_visited_sites_bridge.cc
index 53634855321e95a7c6b6373df295e54800cf89ef..64074f8cf54d51c5cbb2b77046974c166a555bd3 100644
--- a/chrome/browser/android/ntp/most_visited_sites_bridge.cc
+++ b/chrome/browser/android/ntp/most_visited_sites_bridge.cc
@@ -31,9 +31,9 @@ using base::android::ScopedJavaLocalRef;
using base::android::ToJavaArrayOfStrings;
using base::android::ToJavaIntArray;
using ntp_tiles::MostVisitedSites;
-using ntp_tiles::NTPTileSource;
+using ntp_tiles::TileSource;
using ntp_tiles::NTPTilesVector;
-using ntp_tiles::metrics::MostVisitedTileType;
+using ntp_tiles::TileVisualType;
using ntp_tiles::metrics::TileImpression;
class MostVisitedSitesBridge::JavaObserver : public MostVisitedSites::Observer {
@@ -139,9 +139,8 @@ void MostVisitedSitesBridge::RecordPageImpression(
std::vector<TileImpression> tiles;
for (size_t i = 0; i < int_sources.size(); i++) {
- NTPTileSource source = static_cast<NTPTileSource>(int_sources[i]);
- MostVisitedTileType tile_type =
- static_cast<MostVisitedTileType>(int_tile_types[i]);
+ TileSource source = static_cast<TileSource>(int_sources[i]);
+ TileVisualType tile_type = static_cast<TileVisualType>(int_tile_types[i]);
tiles.emplace_back(source, tile_type, GURL(string_tile_urls[i]));
}
@@ -155,9 +154,8 @@ void MostVisitedSitesBridge::RecordOpenedMostVisitedItem(
jint index,
jint tile_type,
jint source) {
- ntp_tiles::metrics::RecordTileClick(
- index, static_cast<NTPTileSource>(source),
- static_cast<MostVisitedTileType>(tile_type));
+ ntp_tiles::metrics::RecordTileClick(index, static_cast<TileSource>(source),
+ static_cast<TileVisualType>(tile_type));
}
// static

Powered by Google App Engine
This is Rietveld 408576698