Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: components/ntp_tiles/tile_visual_type.h

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)
Patch Set: add back histogram enums Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_tiles/tile_visual_type.h
diff --git a/components/ntp_tiles/tile_visual_type.h b/components/ntp_tiles/tile_visual_type.h
new file mode 100644
index 0000000000000000000000000000000000000000..e1bfea102ee1eb6b68cf8c18889f0f4ffef157c9
--- /dev/null
+++ b/components/ntp_tiles/tile_visual_type.h
@@ -0,0 +1,43 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_NTP_TILES_TILE_VISUAL_TYPE_H_
+#define COMPONENTS_NTP_TILES_TILE_VISUAL_TYPE_H_
+
+namespace ntp_tiles {
+
+// The visual type of an NTP tile.
+//
+// These values must stay in sync with the NTPTileVisualType enum in
+// histograms.xml.
+//
+// A Java counterpart will be generated for this enum.
+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.suggestions
+enum TileVisualType {
+ // The icon or thumbnail hasn't loaded yet.
+ NONE = 0,
+ // The item displays a site's actual favicon or touch icon.
+ ICON_REAL = 1,
+ // The item displays a color derived from the site's favicon or touch icon.
+ ICON_COLOR = 2,
+ // The item displays a default gray box in place of an icon.
+ ICON_DEFAULT = 3,
+ // The number of different tile types that get recorded. Entries below this
+ // are not recorded in UMA.
+ NUM_RECORDED_TILE_TYPES,
+
+ // Deleted: THUMBNAIL_LOCAL = 4
+ // Deleted: THUMBNAIL_SERVER = 5
+ // Deleted: THUMBNAIL_DEFAULT = 6
+
+ // The item displays a thumbnail of the page. Used on desktop.
+ THUMBNAIL,
+ // The tile type has not been determined yet. Used on iOS, until we can detect
+ // when all tiles have loaded.
+ UNKNOWN_TILE_TYPE,
+};
+
+} // namespace ntp_tiles
+
+#endif // COMPONENTS_NTP_TILES_TILE_VISUAL_TYPE_H_
« no previous file with comments | « components/ntp_tiles/tile_source.h ('k') | components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698