Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index e3eb69a57bfe340daf0378d74d97fb37d5a4d595..57149242151c60e423bf705d796e35065ec1927c 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -42298,7 +42298,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="NewTabPage.TileType" enum="MostVisitedTileType">
+<histogram name="NewTabPage.TileType" enum="NTPTileType">
<owner>newt@chromium.org</owner>
<summary>
The visual type of each most visited tile displayed on the new tab page,
@@ -42307,7 +42307,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="NewTabPage.TileTypeClicked" enum="MostVisitedTileType">
+<histogram name="NewTabPage.TileTypeClicked" enum="NTPTileType">
<owner>newt@chromium.org</owner>
Michael van Ouwerkerk 2017/03/31 09:01:15 Is newt still the correct owner for this histogram
Marc Treib 2017/04/03 13:23:09 Good point. Yup, I'll do that in a followup.
<summary>
The visual type of the most visited item that the user clicked on, e.g.
@@ -102667,29 +102667,6 @@ from previous Chrome versions.
<int value="11" label="11"/>
</enum>
-<enum name="MostVisitedTileType" type="int">
- <summary>The visual type of a most visited tile on the new tab page.</summary>
- <int value="0" label="None">The icon or thumbnail hasn't loaded yet.</int>
- <int value="1" label="IconReal">
- The item displays a site's actual favicon or touch icon.
- </int>
- <int value="2" label="IconColor">
- The item displays a color derived from the site's favicon or touch icon.
- </int>
- <int value="3" label="IconDefault">
- The item displays a default gray box in place of an icon.
- </int>
- <int value="4" label="ThumbnailLocal">
- The item displays a locally-captured thumbnail of the site content.
- </int>
- <int value="5" label="ThumbnailServer">
- The item displays a server-provided thumbnail of the site content.
- </int>
- <int value="6" label="ThumbnailDefault">
- The item displays a default graphic in place of a thumbnail.
- </int>
-</enum>
-
<enum name="MotionEventToolType" type="int">
<summary>The type of tool that triggers a pointer-type MotionEvent.</summary>
<int value="0" label="Unknown">Unknown tool type.</int>
@@ -104125,6 +104102,29 @@ from previous Chrome versions.
<int value="3" label="Too few URLs, didn't flip tiles 1 and 4"/>
</enum>
+<enum name="NTPTileType" type="int">
+ <summary>The visual type of a most visited tile on the new tab page.</summary>
+ <int value="0" label="None">The icon or thumbnail hasn't loaded yet.</int>
+ <int value="1" label="IconReal">
+ The item displays a site's actual favicon or touch icon.
+ </int>
+ <int value="2" label="IconColor">
+ The item displays a color derived from the site's favicon or touch icon.
+ </int>
+ <int value="3" label="IconDefault">
+ The item displays a default gray box in place of an icon.
+ </int>
+ <int value="4" label="ThumbnailLocal">
+ The item displays a locally-captured thumbnail of the site content.
+ </int>
+ <int value="5" label="ThumbnailServer">
+ The item displays a server-provided thumbnail of the site content.
+ </int>
+ <int value="6" label="ThumbnailDefault">
+ The item displays a default graphic in place of a thumbnail.
+ </int>
+</enum>
+
<enum name="NTSTATUS" type="int">
<int value="-1073741818" label="0xC0000006 - STATUS_IN_PAGE_ERROR"/>
<int value="-1073741808" label="0xC0000010 - STATUS_INVALID_DEVICE_REQUEST"/>

Powered by Google App Engine
This is Rietveld 408576698