chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java - Issue 2790463003: ntp_tiles: Cleanup enum names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)

Patch Set: add back histogram enums Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/FakeMostVisitedSites.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java

index b87ae9d1675cc3e306b5eb5c52ba90c699991385..4d2bec2a5a4e7ff28456363aa17d9256285b25ad 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java

@@ -53,7 +53,6 @@ import org.chromium.chrome.browser.ChromeFeatureList;

import org.chromium.chrome.browser.Features;

import org.chromium.chrome.browser.favicon.LargeIconBridge.LargeIconCallback;

import org.chromium.chrome.browser.ntp.ContextMenuManager;

-import org.chromium.chrome.browser.ntp.NTPTileSource;

import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

import org.chromium.testing.local.LocalRobolectricTestRunner;

@@ -361,7 +360,7 @@ public class TileGroupTest {

mock(OfflinePageBridge.class), TILE_TITLE_LINES);

tileGroup.startObserving(MAX_TILES_TO_FETCH);

reset(mTileGroupObserver);

- Tile tile = new Tile("title", URLS[0], "", 0, NTPTileSource.POPULAR);

+ Tile tile = new Tile("title", URLS[0], "", 0, TileSource.POPULAR);

ViewGroup layout = new FrameLayout(RuntimeEnvironment.application, null);

tileGroup.buildTileView(tile, layout, /* trackLoadTask = */ true, /* condensed = */ false);