Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: chrome/browser/ui/search/search_ipc_router_unittest.cc

Issue 2790463003: ntp_tiles: Cleanup enum names (Closed)
Patch Set: add back histogram enums Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/search/search_ipc_router.h" 5 #include "chrome/browser/ui/search/search_ipc_router.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <tuple> 10 #include <tuple>
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 virtual ~MockSearchIPCRouterDelegate() {} 53 virtual ~MockSearchIPCRouterDelegate() {}
54 54
55 MOCK_METHOD1(OnInstantSupportDetermined, void(bool supports_instant)); 55 MOCK_METHOD1(OnInstantSupportDetermined, void(bool supports_instant));
56 MOCK_METHOD1(FocusOmnibox, void(OmniboxFocusState state)); 56 MOCK_METHOD1(FocusOmnibox, void(OmniboxFocusState state));
57 MOCK_METHOD1(OnDeleteMostVisitedItem, void(const GURL& url)); 57 MOCK_METHOD1(OnDeleteMostVisitedItem, void(const GURL& url));
58 MOCK_METHOD1(OnUndoMostVisitedDeletion, void(const GURL& url)); 58 MOCK_METHOD1(OnUndoMostVisitedDeletion, void(const GURL& url));
59 MOCK_METHOD0(OnUndoAllMostVisitedDeletions, void()); 59 MOCK_METHOD0(OnUndoAllMostVisitedDeletions, void());
60 MOCK_METHOD2(OnLogEvent, void(NTPLoggingEventType event, 60 MOCK_METHOD2(OnLogEvent, void(NTPLoggingEventType event,
61 base::TimeDelta time)); 61 base::TimeDelta time));
62 MOCK_METHOD2(OnLogMostVisitedImpression, 62 MOCK_METHOD2(OnLogMostVisitedImpression,
63 void(int position, ntp_tiles::NTPTileSource tile_source)); 63 void(int position, ntp_tiles::TileSource tile_source));
64 MOCK_METHOD2(OnLogMostVisitedNavigation, 64 MOCK_METHOD2(OnLogMostVisitedNavigation,
65 void(int position, ntp_tiles::NTPTileSource tile_source)); 65 void(int position, ntp_tiles::TileSource tile_source));
66 MOCK_METHOD1(PasteIntoOmnibox, void(const base::string16&)); 66 MOCK_METHOD1(PasteIntoOmnibox, void(const base::string16&));
67 MOCK_METHOD1(OnChromeIdentityCheck, void(const base::string16& identity)); 67 MOCK_METHOD1(OnChromeIdentityCheck, void(const base::string16& identity));
68 MOCK_METHOD0(OnHistorySyncCheck, void()); 68 MOCK_METHOD0(OnHistorySyncCheck, void());
69 }; 69 };
70 70
71 class MockSearchIPCRouterPolicy : public SearchIPCRouter::Policy { 71 class MockSearchIPCRouterPolicy : public SearchIPCRouter::Policy {
72 public: 72 public:
73 virtual ~MockSearchIPCRouterPolicy() {} 73 virtual ~MockSearchIPCRouterPolicy() {}
74 74
75 MOCK_METHOD1(ShouldProcessFocusOmnibox, bool(bool)); 75 MOCK_METHOD1(ShouldProcessFocusOmnibox, bool(bool));
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 .WillOnce(testing::Return(false)); 260 .WillOnce(testing::Return(false));
261 261
262 GetSearchIPCRouter().LogEvent(GetSearchIPCRouterSeqNo(), NTP_ALL_TILES_LOADED, 262 GetSearchIPCRouter().LogEvent(GetSearchIPCRouterSeqNo(), NTP_ALL_TILES_LOADED,
263 delta); 263 delta);
264 } 264 }
265 265
266 TEST_F(SearchIPCRouterTest, ProcessLogMostVisitedImpressionMsg) { 266 TEST_F(SearchIPCRouterTest, ProcessLogMostVisitedImpressionMsg) {
267 NavigateAndCommitActiveTab(GURL(chrome::kChromeSearchLocalNtpUrl)); 267 NavigateAndCommitActiveTab(GURL(chrome::kChromeSearchLocalNtpUrl));
268 SetupMockDelegateAndPolicy(); 268 SetupMockDelegateAndPolicy();
269 MockSearchIPCRouterPolicy* policy = GetSearchIPCRouterPolicy(); 269 MockSearchIPCRouterPolicy* policy = GetSearchIPCRouterPolicy();
270 EXPECT_CALL(*mock_delegate(), 270 EXPECT_CALL(
271 OnLogMostVisitedImpression( 271 *mock_delegate(),
272 3, ntp_tiles::NTPTileSource::SUGGESTIONS_SERVICE)) 272 OnLogMostVisitedImpression(3, ntp_tiles::TileSource::SUGGESTIONS_SERVICE))
273 .Times(1); 273 .Times(1);
274 EXPECT_CALL(*policy, ShouldProcessLogEvent()).Times(1) 274 EXPECT_CALL(*policy, ShouldProcessLogEvent()).Times(1)
275 .WillOnce(testing::Return(true)); 275 .WillOnce(testing::Return(true));
276 276
277 GetSearchIPCRouter().LogMostVisitedImpression( 277 GetSearchIPCRouter().LogMostVisitedImpression(
278 GetSearchIPCRouterSeqNo(), 3, 278 GetSearchIPCRouterSeqNo(), 3, ntp_tiles::TileSource::SUGGESTIONS_SERVICE);
279 ntp_tiles::NTPTileSource::SUGGESTIONS_SERVICE);
280 } 279 }
281 280
282 TEST_F(SearchIPCRouterTest, ProcessLogMostVisitedNavigationMsg) { 281 TEST_F(SearchIPCRouterTest, ProcessLogMostVisitedNavigationMsg) {
283 NavigateAndCommitActiveTab(GURL(chrome::kChromeSearchLocalNtpUrl)); 282 NavigateAndCommitActiveTab(GURL(chrome::kChromeSearchLocalNtpUrl));
284 SetupMockDelegateAndPolicy(); 283 SetupMockDelegateAndPolicy();
285 MockSearchIPCRouterPolicy* policy = GetSearchIPCRouterPolicy(); 284 MockSearchIPCRouterPolicy* policy = GetSearchIPCRouterPolicy();
286 EXPECT_CALL(*mock_delegate(), 285 EXPECT_CALL(
287 OnLogMostVisitedNavigation( 286 *mock_delegate(),
288 3, ntp_tiles::NTPTileSource::SUGGESTIONS_SERVICE)) 287 OnLogMostVisitedNavigation(3, ntp_tiles::TileSource::SUGGESTIONS_SERVICE))
289 .Times(1); 288 .Times(1);
290 EXPECT_CALL(*policy, ShouldProcessLogEvent()).Times(1) 289 EXPECT_CALL(*policy, ShouldProcessLogEvent()).Times(1)
291 .WillOnce(testing::Return(true)); 290 .WillOnce(testing::Return(true));
292 291
293 GetSearchIPCRouter().LogMostVisitedNavigation( 292 GetSearchIPCRouter().LogMostVisitedNavigation(
294 GetSearchIPCRouterSeqNo(), 3, 293 GetSearchIPCRouterSeqNo(), 3, ntp_tiles::TileSource::SUGGESTIONS_SERVICE);
295 ntp_tiles::NTPTileSource::SUGGESTIONS_SERVICE);
296 } 294 }
297 295
298 TEST_F(SearchIPCRouterTest, ProcessChromeIdentityCheckMsg) { 296 TEST_F(SearchIPCRouterTest, ProcessChromeIdentityCheckMsg) {
299 NavigateAndCommitActiveTab(GURL(chrome::kChromeSearchLocalNtpUrl)); 297 NavigateAndCommitActiveTab(GURL(chrome::kChromeSearchLocalNtpUrl));
300 SetupMockDelegateAndPolicy(); 298 SetupMockDelegateAndPolicy();
301 MockSearchIPCRouterPolicy* policy = GetSearchIPCRouterPolicy(); 299 MockSearchIPCRouterPolicy* policy = GetSearchIPCRouterPolicy();
302 const base::string16 test_identity = base::ASCIIToUTF16("foo@bar.com"); 300 const base::string16 test_identity = base::ASCIIToUTF16("foo@bar.com");
303 EXPECT_CALL(*mock_delegate(), OnChromeIdentityCheck(test_identity)).Times(1); 301 EXPECT_CALL(*mock_delegate(), OnChromeIdentityCheck(test_identity)).Times(1);
304 EXPECT_CALL(*policy, ShouldProcessChromeIdentityCheck()).Times(1) 302 EXPECT_CALL(*policy, ShouldProcessChromeIdentityCheck()).Times(1)
305 .WillOnce(testing::Return(true)); 303 .WillOnce(testing::Return(true));
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
582 TEST_F(SearchIPCRouterTest, DoNotSendSubmitMsg) { 580 TEST_F(SearchIPCRouterTest, DoNotSendSubmitMsg) {
583 NavigateAndCommitActiveTab(GURL(chrome::kChromeSearchLocalNtpUrl)); 581 NavigateAndCommitActiveTab(GURL(chrome::kChromeSearchLocalNtpUrl));
584 SetupMockDelegateAndPolicy(); 582 SetupMockDelegateAndPolicy();
585 MockSearchIPCRouterPolicy* policy = GetSearchIPCRouterPolicy(); 583 MockSearchIPCRouterPolicy* policy = GetSearchIPCRouterPolicy();
586 EXPECT_CALL(*policy, ShouldSubmitQuery()).Times(1) 584 EXPECT_CALL(*policy, ShouldSubmitQuery()).Times(1)
587 .WillOnce(testing::Return(false)); 585 .WillOnce(testing::Return(false));
588 586
589 EXPECT_CALL(*mock_search_box(), Submit(_, _)).Times(0); 587 EXPECT_CALL(*mock_search_box(), Submit(_, _)).Times(0);
590 GetSearchIPCRouter().Submit(base::string16(), EmbeddedSearchRequestParams()); 588 GetSearchIPCRouter().Submit(base::string16(), EmbeddedSearchRequestParams());
591 } 589 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/search/search_ipc_router.cc ('k') | chrome/browser/ui/search/search_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698