Chromium Code Reviews
Help | Chromium Project | Sign in
(57)

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 6 days ago by dgozman
Modified:
1 week, 5 days ago
Reviewers:
caseq, alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate usages of Target to RuntimeModel where makes sense This is in a preparation to removing always-initialized target.runtimeModel. Instead we will only instantiate one for targets with JS support. CL also fixes a lot of compilation errors (some of them were real bugs) which are now suddenly being caught by closure. BUG=none Review-Url: https://codereview.chromium.org/2752403002 Cr-Commit-Position: refs/heads/master@{#457941} Committed: https://chromium.googlesource.com/chromium/src/+/9f18e4305df8b79a0b0ef7d94430b7ea76dfe1f6

Patch Set 1 #

Patch Set 2 : compilation errors #

Total comments: 15

Patch Set 3 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -194 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/console/console-links-on-messages-before-inspection.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/source-map-http-header.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/dont-diverge-script-evaluated-twice.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 4 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersUtils.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/OverlayController.js View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/object_ui/CustomPreviewComponent.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/perf_ui/LineLevelProfile.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapProfilerPanel.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js View 1 32 chunks +106 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 10 chunks +45 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js View 1 2 3 chunks +18 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js View 1 7 chunks +47 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +1 line, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 22 (13 generated)
dgozman
Could you please take a look?
1 week, 6 days ago (2017-03-17 00:40:50 UTC) #4
dgozman
+caseq
1 week, 5 days ago (2017-03-17 17:43:01 UTC) #9
alph
lgtm
1 week, 5 days ago (2017-03-17 18:20:27 UTC) #10
caseq
lgtm https://codereview.chromium.org/2752403002/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/source-map-http-header.html File third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/source-map-http-header.html (right): https://codereview.chromium.org/2752403002/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/source-map-http-header.html#newcode19 third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/source-map-http-header.html:19: var mainTarget = SDK.targetManager.mainTarget(); Nuke this. https://codereview.chromium.org/2752403002/diff/20001/third_party/WebKit/LayoutTests/inspector/sources/dont-diverge-script-evaluated-twice.html File ...
1 week, 5 days ago (2017-03-17 18:30:44 UTC) #11
dgozman
Thank you for review! https://codereview.chromium.org/2752403002/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/source-map-http-header.html File third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/source-map-http-header.html (right): https://codereview.chromium.org/2752403002/diff/20001/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/source-map-http-header.html#newcode19 third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/source-map-http-header.html:19: var mainTarget = SDK.targetManager.mainTarget(); On ...
1 week, 5 days ago (2017-03-17 21:43:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752403002/40001
1 week, 5 days ago (2017-03-17 21:45:16 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/386719)
1 week, 5 days ago (2017-03-18 01:20:27 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752403002/40001
1 week, 5 days ago (2017-03-18 02:03:13 UTC) #19
commit-bot: I haz the power
1 week, 5 days ago (2017-03-18 02:56:24 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9f18e4305df8b79a0b0ef7d94430...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46