Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
index 921bec5562cca0d3403ed02021cff39ff3ce6730..d7e0df0e33303c69fbefbf23779cf3df171aa684 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
@@ -801,11 +801,12 @@ Console.ConsoleView = class extends UI.VBox {
var message;
if (!exceptionDetails) {
message = new ConsoleModel.ConsoleMessage(
- result.target(), ConsoleModel.ConsoleMessage.MessageSource.JS, level, '',
+ result.runtimeModel().target(), ConsoleModel.ConsoleMessage.MessageSource.JS, level, '',
ConsoleModel.ConsoleMessage.MessageType.Result, undefined, undefined, undefined, undefined, [result]);
} else {
message = ConsoleModel.ConsoleMessage.fromException(
- result.target(), exceptionDetails, ConsoleModel.ConsoleMessage.MessageType.Result, undefined, undefined);
+ result.runtimeModel(), exceptionDetails, ConsoleModel.ConsoleMessage.MessageType.Result, undefined,
+ undefined);
}
message.setOriginatingMessage(originatingConsoleMessage);
ConsoleModel.consoleModel.addMessage(message);

Powered by Google App Engine
This is Rietveld 408576698