Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js b/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
index d371a50b508158127bacc6a52eba2b82d0ac124a..422c7138f3832b7f941843c33e968edced6db9a6 100644
--- a/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js
@@ -207,7 +207,7 @@ ConsoleModel.ConsoleModel = class extends Common.Object {
_exceptionThrown(runtimeModel, event) {
var exceptionWithTimestamp = /** @type {!SDK.RuntimeModel.ExceptionWithTimestamp} */ (event.data);
var consoleMessage = ConsoleModel.ConsoleMessage.fromException(
- runtimeModel.target(), exceptionWithTimestamp.details, undefined, exceptionWithTimestamp.timestamp, undefined);
+ runtimeModel, exceptionWithTimestamp.details, undefined, exceptionWithTimestamp.timestamp, undefined);
consoleMessage.setExceptionId(exceptionWithTimestamp.details.exceptionId);
this.addMessage(consoleMessage);
}
@@ -460,18 +460,19 @@ ConsoleModel.ConsoleMessage = class {
}
/**
- * @param {!SDK.Target} target
+ * @param {!SDK.RuntimeModel} runtimeModel
* @param {!Protocol.Runtime.ExceptionDetails} exceptionDetails
* @param {string=} messageType
* @param {number=} timestamp
* @param {string=} forceUrl
* @return {!ConsoleModel.ConsoleMessage}
*/
- static fromException(target, exceptionDetails, messageType, timestamp, forceUrl) {
+ static fromException(runtimeModel, exceptionDetails, messageType, timestamp, forceUrl) {
return new ConsoleModel.ConsoleMessage(
- target, ConsoleModel.ConsoleMessage.MessageSource.JS, ConsoleModel.ConsoleMessage.MessageLevel.Error,
- SDK.RuntimeModel.simpleTextFromException(exceptionDetails), messageType, forceUrl || exceptionDetails.url,
- exceptionDetails.lineNumber, exceptionDetails.columnNumber, undefined,
+ runtimeModel.target(), ConsoleModel.ConsoleMessage.MessageSource.JS,
+ ConsoleModel.ConsoleMessage.MessageLevel.Error, SDK.RuntimeModel.simpleTextFromException(exceptionDetails),
+ messageType, forceUrl || exceptionDetails.url, exceptionDetails.lineNumber, exceptionDetails.columnNumber,
+ undefined,
exceptionDetails.exception ?
[SDK.RemoteObject.fromLocalObject(exceptionDetails.text), exceptionDetails.exception] :
undefined,

Powered by Google App Engine
This is Rietveld 408576698