third_party/WebKit/Source/devtools/front_end/profiler/HeapProfilerPanel.js - Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapProfilerPanel.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)

Patch Set: review comments addressed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/perf_ui/LineLevelProfile.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapProfilerPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfilerPanel.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfilerPanel.js

index fdb7fc82fedff0507d78eae8bf5073681499b383..2f7594a43765b48200c214785130d9cfa19c0f64 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfilerPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfilerPanel.js

@@ -29,15 +29,15 @@ Profiler.HeapProfilerPanel = class extends Profiler.ProfilesPanel {

return;

var object = /** @type {!SDK.RemoteObject} */ (target);

- var objectId = object.objectId;

- if (!objectId)

+ if (!object.objectId)

return;

+ var objectId = /** @type {string} */ (object.objectId);

var heapProfiles = Profiler.ProfileTypeRegistry.instance.heapSnapshotProfileType.getProfiles();

if (!heapProfiles.length)

return;

- var heapProfilerModel = object.target().model(SDK.HeapProfilerModel);

+ var heapProfilerModel = object.runtimeModel().heapProfilerModel();

if (!heapProfilerModel)

return;