Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
index b0394b65015f5eb7306fce5e9ef8d5d4846ad874..b6d4378f881608d8dfd771da4ddf8d60ced25743 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js
@@ -1072,7 +1072,7 @@ SDK.DOMModel = class extends SDK.SDKModel {
* @param {!SDK.RemoteObject} object
*/
static highlightObjectAsDOMNode(object) {
- var domModel = SDK.DOMModel.fromTarget(object.target());
+ var domModel = SDK.DOMModel.fromTarget(object.runtimeModel().target());
if (domModel)
domModel.highlightDOMNode(undefined, undefined, undefined, object.objectId);
}
@@ -1851,7 +1851,7 @@ SDK.DOMModel = class extends SDK.SDKModel {
*/
pushObjectAsNodeToFrontend(object, callback) {
if (object.isNode())
- this.pushNodeToFrontend(object.objectId, callback);
+ this.pushNodeToFrontend(/** @type {string} */ (object.objectId), callback);
else
callback(null);
}

Powered by Google App Engine
This is Rietveld 408576698