Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: third_party/WebKit/Source/devtools/front_end/Tests.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/Tests.js
diff --git a/third_party/WebKit/Source/devtools/front_end/Tests.js b/third_party/WebKit/Source/devtools/front_end/Tests.js
index 7d10d989b3266dd92a1a64f8f527759b3f9a071b..5c345c96759e0e3dc280c1994d95231e42997751 100644
--- a/third_party/WebKit/Source/devtools/front_end/Tests.js
+++ b/third_party/WebKit/Source/devtools/front_end/Tests.js
@@ -260,7 +260,7 @@
*/
TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh = function() {
var test = this;
- var debuggerModel = SDK.DebuggerModel.fromTarget(SDK.targetManager.mainTarget());
+ var debuggerModel = SDK.targetManager.mainTarget().model(SDK.DebuggerModel);
debuggerModel.addEventListener(SDK.DebuggerModel.Events.GlobalObjectCleared, waitUntilScriptIsParsed);
this.showPanel('elements').then(function() {
@@ -345,7 +345,7 @@
// Tests that debugger works correctly if pause event occurs when DevTools
// frontend is being loaded.
TestSuite.prototype.testPauseWhenLoadingDevTools = function() {
- var debuggerModel = SDK.DebuggerModel.fromTarget(SDK.targetManager.mainTarget());
+ var debuggerModel = SDK.targetManager.mainTarget().model(SDK.DebuggerModel);
if (debuggerModel.debuggerPausedDetails)
return;
@@ -577,8 +577,7 @@
this._waitForTargets(2, callback.bind(this));
function callback() {
- var target = SDK.targetManager.targets(SDK.Target.Capability.JS)[0];
- var debuggerModel = SDK.DebuggerModel.fromTarget(target);
+ var debuggerModel = SDK.targetManager.models(SDK.DebuggerModel)[0];
if (debuggerModel.isPaused()) {
this.releaseControl();
return;
@@ -598,7 +597,7 @@
};
TestSuite.prototype.waitForDebuggerPaused = function() {
- var debuggerModel = SDK.DebuggerModel.fromTarget(SDK.targetManager.mainTarget());
+ var debuggerModel = SDK.targetManager.mainTarget().model(SDK.DebuggerModel);
if (debuggerModel.debuggerPausedDetails)
return;

Powered by Google App Engine
This is Rietveld 408576698