third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js - Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)

Patch Set: review comments addressed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/object_ui/CustomPreviewComponent.js ('k') | third_party/WebKit/Source/devtools/front_end/perf_ui/LineLevelProfile.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js

diff --git a/third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js b/third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js

index 074fcc34e55a197da273a2e36a2b31dc0efad3c6..04ed56fa04b84ffc36c8debd891cdd616a180919 100644

--- a/third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js

+++ b/third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js

@@ -327,7 +327,7 @@ ObjectUI.JavaScriptAutocomplete.completionsForExpression = function(expressionSt

* @param {!Protocol.Runtime.ExceptionDetails=} exceptionDetails

function receivedPropertyNamesFromEval(result, exceptionDetails) {

- executionContext.target().runtimeModel.releaseObjectGroup('completion');

+ executionContext.runtimeModel.releaseObjectGroup('completion');

if (result && !exceptionDetails)

receivedPropertyNames(/** @type {!Object} */ (result.value));

else

@@ -338,7 +338,7 @@ ObjectUI.JavaScriptAutocomplete.completionsForExpression = function(expressionSt

* @param {?Object} object

function receivedPropertyNames(object) {

- executionContext.target().runtimeModel.releaseObjectGroup('completion');

+ executionContext.runtimeModel.releaseObjectGroup('completion');

if (!object) {

fulfill([]);

return;