third_party/WebKit/Source/devtools/front_end/main/OverlayController.js - Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/OverlayController.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)

Patch Set: review comments addressed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | third_party/WebKit/Source/devtools/front_end/object_ui/CustomPreviewComponent.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/main/OverlayController.js

diff --git a/third_party/WebKit/Source/devtools/front_end/main/OverlayController.js b/third_party/WebKit/Source/devtools/front_end/main/OverlayController.js

index deffeb651b98c58e193b4e3706a8784c1f708ccc..e6800cef0ad6b286bec3dfd691eff010347722f4 100644

--- a/third_party/WebKit/Source/devtools/front_end/main/OverlayController.js

+++ b/third_party/WebKit/Source/devtools/front_end/main/OverlayController.js

@@ -18,10 +18,8 @@ Main.OverlayController = class {

}

_updateAllOverlays() {

- for (var target of SDK.targetManager.targets(SDK.Target.Capability.Browser)) {

- this._updateTargetOverlay(

- /** @type {!SDK.DebuggerModel} */ (SDK.DebuggerModel.fromTarget(target)));

- }

+ for (var debuggerModel of SDK.targetManager.models(SDK.DebuggerModel))

+ this._updateTargetOverlay(debuggerModel);

}

/**