third_party/WebKit/Source/devtools/front_end/components/Linkifier.js - Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)

Patch Set: review comments addressed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js ('k') | third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

index 04df5be060ba7528059a111a5b401de072f24ad5..a155b724ff31549d7683dbd81025b6ac271fdd4c 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

@@ -153,7 +153,7 @@ Components.Linkifier = class {

sourceURL ? Components.Linkifier.linkifyURL(sourceURL, undefined, classes, lineNumber, columnNumber) : null;

if (!target || target.isDisposed())

return fallbackAnchor;

- var debuggerModel = SDK.DebuggerModel.fromTarget(target);

+ var debuggerModel = target.model(SDK.DebuggerModel);

if (!debuggerModel)

return fallbackAnchor;

@@ -228,7 +228,7 @@ Components.Linkifier = class {

if (target.isDisposed())

return fallbackAnchor;

- var debuggerModel = SDK.DebuggerModel.fromTarget(target);

+ var debuggerModel = target.model(SDK.DebuggerModel);

var rawLocations = debuggerModel.createRawLocationsByStackTrace(stackTrace);

if (rawLocations.length === 0)

return fallbackAnchor;