Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersUtils.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersUtils.js b/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersUtils.js
index ba611dfdc10fd48dc7696b99af28e965d5eaedd7..43ea49f51d30c9c08af59ced9ebbec08d1b089ed 100644
--- a/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersUtils.js
@@ -12,7 +12,7 @@ EventListeners.EventListenerObjectInInspectedPage;
* @return {!Promise<!EventListeners.FrameworkEventListenersObject>}
*/
EventListeners.frameworkEventListeners = function(object) {
- if (!object.target().hasDOMCapability()) {
+ if (!object.runtimeModel().target().hasDOMCapability()) {
// TODO(kozyatinskiy): figure out how this should work for |window|.
return Promise.resolve(
/** @type {!EventListeners.FrameworkEventListenersObject} */ ({eventListeners: [], internalHandlers: null}));
@@ -177,7 +177,7 @@ EventListeners.frameworkEventListeners = function(object) {
if (!location)
throw new Error('Empty event listener\'s location');
return new SDK.EventListener(
- handler._target, object, type, useCapture, passive, once, handler, originalHandler, location,
+ handler.runtimeModel(), object, type, useCapture, passive, once, handler, originalHandler, location,
removeFunctionObject, SDK.EventListener.Origin.FrameworkUser);
}
}

Powered by Google App Engine
This is Rietveld 408576698