third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html - Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)

Patch Set: review comments addressed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/source-map-http-header.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/dont-diverge-script-evaluated-twice.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

index 3b147c61c96bf33178de9ee7fd32db490547ff10..7a10154d209b086ded9d7441c995998db2bffff4 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

@@ -17,7 +17,7 @@ function test()

InspectorTest.addSniffer(Snippets.ScriptSnippetModel.prototype, "_printRunScriptResult", dumpResult);

Snippets.scriptSnippetModel.evaluateScriptSnippet(context, uiSourceCode);

var target = context.target();

- var mapping = Snippets.scriptSnippetModel._mappingForDebuggerModel.get(SDK.DebuggerModel.fromTarget(target));

+ var mapping = Snippets.scriptSnippetModel._mappingForDebuggerModel.get(target.model(SDK.DebuggerModel));

var evaluationSourceURL = mapping._evaluationSourceURL(uiSourceCode);

var snippetId = Snippets.scriptSnippetModel._snippetIdForUISourceCode.get(uiSourceCode);

InspectorTest.addResult("Last evaluation source url for snippet: " + evaluationSourceURL);

@@ -168,7 +168,7 @@ function test()

var context = UI.context.flavor(SDK.ExecutionContext);

resetSnippetsSettings();

- var snippetScriptMapping = Snippets.scriptSnippetModel.snippetScriptMapping(SDK.DebuggerModel.fromTarget(SDK.targetManager.targets()[0]));

+ var snippetScriptMapping = Snippets.scriptSnippetModel.snippetScriptMapping(SDK.targetManager.models(SDK.DebuggerModel)[0]);

Snippets.scriptSnippetModel.project().createFile("", null, "", step2.bind(this));

@@ -241,7 +241,7 @@ function test()

}

resetSnippetsSettings();

- var snippetScriptMapping = Snippets.scriptSnippetModel.snippetScriptMapping(SDK.DebuggerModel.fromTarget(SDK.targetManager.targets()[0]));

+ var snippetScriptMapping = Snippets.scriptSnippetModel.snippetScriptMapping(SDK.targetManager.models(SDK.DebuggerModel)[0]);

Snippets.scriptSnippetModel.project().createFile("", null, "", step3.bind(this));