Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js b/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
index 1a382a971a6435cf0b096a8531e259928a30066e..f43be6452e90347cddf9ebf9af48900a6cfd2f8e 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js
@@ -317,10 +317,9 @@ Sources.SourceMapNamesResolver.resolveThisObject = function(callFrame) {
* @param {?Protocol.Runtime.RemoteObject} evaluateResult
*/
function onEvaluated(callback, evaluateResult) {
- var remoteObject = evaluateResult ?
- callFrame.debuggerModel.target().runtimeModel.createRemoteObject(evaluateResult) :
- callFrame.thisObject();
- callback(remoteObject);
+ var remoteObject = evaluateResult ? callFrame.debuggerModel.runtimeModel().createRemoteObject(evaluateResult) :
+ callFrame.thisObject();
+ callback(/** @type {!SDK.RemoteObject} */ (remoteObject));
}
};
@@ -363,6 +362,14 @@ Sources.SourceMapNamesResolver.RemoteObject = class extends SDK.RemoteObject {
/**
* @override
+ * @return {!Protocol.Runtime.RemoteObjectId|undefined}
+ */
+ get objectId() {
+ return this._object.objectId;
+ }
+
+ /**
+ * @override
* @return {string}
*/
get type() {
@@ -379,6 +386,14 @@ Sources.SourceMapNamesResolver.RemoteObject = class extends SDK.RemoteObject {
/**
* @override
+ * @return {*}
+ */
+ get value() {
+ return this._object.value;
+ }
+
+ /**
+ * @override
* @return {string|undefined}
*/
get description() {
@@ -395,6 +410,14 @@ Sources.SourceMapNamesResolver.RemoteObject = class extends SDK.RemoteObject {
/**
* @override
+ * @return {!Protocol.Runtime.ObjectPreview|undefined}
+ */
+ get preview() {
+ return this._object.preview;
+ }
+
+ /**
+ * @override
* @return {number}
*/
arrayLength() {
@@ -483,6 +506,15 @@ Sources.SourceMapNamesResolver.RemoteObject = class extends SDK.RemoteObject {
/**
* @override
+ * @param {!Array.<string>} propertyPath
+ * @param {function(?SDK.RemoteObject, boolean=)} callback
+ */
+ getProperty(propertyPath, callback) {
+ this._object.getProperty(propertyPath, callback);
+ }
+
+ /**
+ * @override
* @return {!Promise<?Array<!SDK.EventListener>>}
*/
eventListeners() {
@@ -520,15 +552,14 @@ Sources.SourceMapNamesResolver.RemoteObject = class extends SDK.RemoteObject {
/**
* @override
- * @return {!SDK.Target}
*/
- target() {
- return this._object.target();
+ release() {
+ this._object.release();
}
/**
* @override
- * @return {?SDK.DebuggerModel}
+ * @return {!SDK.DebuggerModel}
*/
debuggerModel() {
return this._object.debuggerModel();
@@ -536,6 +567,14 @@ Sources.SourceMapNamesResolver.RemoteObject = class extends SDK.RemoteObject {
/**
* @override
+ * @return {!SDK.RuntimeModel}
+ */
+ runtimeModel() {
+ return this._object.runtimeModel();
+ }
+
+ /**
+ * @override
* @return {boolean}
*/
isNode() {

Powered by Google App Engine
This is Rietveld 408576698