Migrate WTF::Vector::append() to ::push_back() [part 1 of N]

Migrate WTF::Vector::append() to ::push_back() [part 1 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/bindings/*. There
are too many references to change them all at once, so this CL is part 1
of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
Committed: https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a
Cr-Commit-Position: refs/heads/master@{#437074}

[pilgrim_google, 2016-12-06 22:04:02]

Description was changed from

==========
Migrate WTF::Vector::append() to ::push_back()

WIP

BUG=
==========

to

==========
Migrate WTF::Vector::append() to ::push_back() [part 1 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/bindings/*. There
are too many references to change them all at once, so this CL is part 1
of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

[pilgrim_google, 2016-12-06 22:04:03]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, yutak@chromium.org

[pilgrim_google, 2016-12-06 22:04:17]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 22:04:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 22:51:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 22:51:43]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[haraken, 2016-12-06 23:50:16]

LGTM

Can you send a PSA to blink-dev (not about this specific case but about the
overall unification plan)?

[pilgrim_google, 2016-12-07 00:44:13]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2016-12-07 00:44:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 01:13:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 01:13:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pilgrim_google, 2016-12-07 14:46:40]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2016-12-07 14:46:41]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2554693003/#ps40001
(title: "cl format")

[commit-bot: I haz the power, 2016-12-07 14:46:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 14:49:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 14:49:32]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pilgrim_google, 2016-12-07 15:35:42]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2016-12-07 15:35:42]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2554693003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-07 15:35:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 19:23:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 19:23:53]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pilgrim_google, 2016-12-07 20:00:01]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2016-12-07 20:00:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 21:56:50]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481140801309280,
"parent_rev": "ad81038d35d1da3d2c7c3599a9ac13570ef76e29", "commit_rev":
"573692c1d9db102d8cb24bfac769c4dc7b08c981"}

[commit-bot: I haz the power, 2016-12-07 21:57:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-07 22:00:11]

Description was changed from

==========
Migrate WTF::Vector::append() to ::push_back() [part 1 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/bindings/*. There
are too many references to change them all at once, so this CL is part 1
of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::Vector::append() to ::push_back() [part 1 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/bindings/*. There
are too many references to change them all at once, so this CL is part 1
of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431

Committed: https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a
Cr-Commit-Position: refs/heads/master@{#437074}
==========

[commit-bot: I haz the power, 2016-12-07 22:00:12]

Patchset 4 (id:??) landed as
https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a
Cr-Commit-Position: refs/heads/master@{#437074}