third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp - Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp

Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N] (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp

index 19cd82e6f5b069e69bf1e2de49a8e7f3a08bf1c5..3a3b637acd1e14c04beb1355fd09ed4b988f5117 100644

--- a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp

@@ -15,12 +15,12 @@ TEST(TraceWrapperMemberTest, HeapVectorSwap) {

HeapVector<Wrapper> vector1;

DeathAwareScriptWrappable* parent1 = DeathAwareScriptWrappable::create();

DeathAwareScriptWrappable* child1 = DeathAwareScriptWrappable::create();

- vector1.append(Wrapper(parent1, child1));

+ vector1.push_back(Wrapper(parent1, child1));

HeapVector<Wrapper> vector2;

DeathAwareScriptWrappable* parent2 = DeathAwareScriptWrappable::create();

DeathAwareScriptWrappable* child2 = DeathAwareScriptWrappable::create();

- vector2.append(Wrapper(parent2, child2));

+ vector2.push_back(Wrapper(parent2, child2));

swap(vector1, vector2, parent1, parent2);

EXPECT_EQ(parent1, vector1.front().parent());

@@ -33,11 +33,11 @@ TEST(TraceWrapperMemberTest, HeapVectorSwap2) {

HeapVector<Wrapper> vector1;

DeathAwareScriptWrappable* parent1 = DeathAwareScriptWrappable::create();

DeathAwareScriptWrappable* child1 = DeathAwareScriptWrappable::create();

- vector1.append(Wrapper(parent1, child1));

+ vector1.push_back(Wrapper(parent1, child1));

HeapVector<Member<DeathAwareScriptWrappable>> vector2;

DeathAwareScriptWrappable* child2 = DeathAwareScriptWrappable::create();

- vector2.append(child2);

+ vector2.push_back(child2);

swap(vector1, vector2, parent1);

EXPECT_EQ(1u, vector1.size());