Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N] (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
diff --git a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
index 8bc97f7db2b855cc70d4aa32936141c8447f52cf..6fcdb353d5f4ac348bd760d88467d42296a911f2 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
+++ b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
@@ -218,7 +218,7 @@ static IDBKey* createIDBKeyFromValue(v8::Isolate* isolate,
return nullptr;
if (stack.size() >= maximumDepth)
return nullptr;
- stack.append(array);
+ stack.push_back(array);
IDBKey::KeyArray subkeys;
uint32_t length = array->Length();
@@ -235,9 +235,9 @@ static IDBKey* createIDBKeyFromValue(v8::Isolate* isolate,
IDBKey* subkey = createIDBKeyFromValue(
isolate, item, stack, exceptionState, allowExperimentalTypes);
if (!subkey)
- subkeys.append(IDBKey::createInvalid());
+ subkeys.push_back(IDBKey::createInvalid());
else
- subkeys.append(subkey);
+ subkeys.push_back(subkey);
}
stack.pop_back();
@@ -376,7 +376,7 @@ static IDBKey* createIDBKeyFromValueAndKeyPath(
isolate, value, array[i], exceptionState, allowExperimentalTypes);
if (!key)
return nullptr;
- result.append(key);
+ result.push_back(key);
}
return IDBKey::createArray(result);
}

Powered by Google App Engine
This is Rietveld 408576698