third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp - Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N] (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

index df79a052a3f2f240c70c785eb8261017ccc3723b..9b1c254946b3f6d8ac4039224ba44d142abc2993 100644

--- a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

@@ -269,7 +269,7 @@ void RejectedPromises::processQueueNow(std::unique_ptr<MessageQueue> queue) {

if (!message->hasHandler()) {

message->report();

message->makePromiseWeak();

- m_reportedAsErrors.append(std::move(message));

+ m_reportedAsErrors.push_back(std::move(message));

if (m_reportedAsErrors.size() > maxReportedHandlersPendingResolution)

m_reportedAsErrors.remove(0, maxReportedHandlersPendingResolution / 10);

}