third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp - Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N] (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp b/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

index 1bedf5915afbc6a6a26e3e76ad99fba7f107690b..9af7fc830b426f13dd2fbe01296185eb8fd70389 100644

--- a/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

@@ -196,7 +196,7 @@ Vector<String> Dictionary::getPropertyNames(

if (!stringKey.prepare(isolate(), exceptionState))

return Vector<String>();

- names.append(stringKey);

+ names.push_back(stringKey);

}

return names;