third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h - Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N] (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h b/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

index c29ad4c6f257a10c79446ef6c4f3c456b15ae4a4..adcc8ac6413ef7fa8b0cb4a8d5994b53fc197c54 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h

@@ -656,7 +656,7 @@ class CORE_EXPORT ScriptValueDeserializer {

uint32_t numProperties,

v8::Local<v8::Value>*);

bool doDeserialize();

- void push(v8::Local<v8::Value> value) { m_stack.append(value); };

+ void push(v8::Local<v8::Value> value) { m_stack.push_back(value); };

void pop(unsigned length) {

ASSERT(length <= m_stack.size());

m_stack.shrink(m_stack.size() - length);