Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp

Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N] (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
index e45fd531a283d49de018fe20c1dac9215d7af7de..0452b152768e12b6c25dafce5aa8636c4c1c89b0 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
@@ -1149,7 +1149,7 @@ ScriptValueSerializer::StateBase* ScriptValueSerializer::writeFileList(
if (appendFileInfo(file, &blobIndex)) {
ASSERT(!i || blobIndex > 0);
ASSERT(blobIndex >= 0);
- blobIndices.append(blobIndex);
+ blobIndices.push_back(blobIndex);
}
}
if (!blobIndices.isEmpty())
@@ -1397,7 +1397,7 @@ bool ScriptValueSerializer::appendBlobInfo(const String& uuid,
if (!m_blobInfo)
return false;
*index = m_blobInfo->size();
- m_blobInfo->append(WebBlobInfo(uuid, type, size));
+ m_blobInfo->push_back(WebBlobInfo(uuid, type, size));
return true;
}
@@ -1411,8 +1411,8 @@ bool ScriptValueSerializer::appendFileInfo(const File* file, int* index) {
*index = m_blobInfo->size();
// FIXME: transition WebBlobInfo.lastModified to be milliseconds-based also.
double lastModified = lastModifiedMS / msPerSecond;
- m_blobInfo->append(WebBlobInfo(file->uuid(), file->path(), file->name(),
- file->type(), lastModified, size));
+ m_blobInfo->push_back(WebBlobInfo(file->uuid(), file->path(), file->name(),
+ file->type(), lastModified, size));
return true;
}
@@ -2475,7 +2475,7 @@ bool ScriptValueDeserializer::completeSet(uint32_t length,
void ScriptValueDeserializer::pushObjectReference(
const v8::Local<v8::Value>& object) {
- m_objectPool.append(object);
+ m_objectPool.push_back(object);
}
bool ScriptValueDeserializer::tryGetTransferredMessagePort(
@@ -2641,8 +2641,8 @@ v8::Local<v8::Value> ScriptValueDeserializer::element(unsigned index) {
void ScriptValueDeserializer::openComposite(
const v8::Local<v8::Value>& object) {
uint32_t newObjectReference = m_objectPool.size();
- m_openCompositeReferenceStack.append(newObjectReference);
- m_objectPool.append(object);
+ m_openCompositeReferenceStack.push_back(newObjectReference);
+ m_objectPool.push_back(object);
}
bool ScriptValueDeserializer::closeComposite(v8::Local<v8::Value>* object) {

Powered by Google App Engine
This is Rietveld 408576698