third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp - Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N] (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

index 43a67b6a4f3c6ba79b5b3700d04f99291e01f479..f12153a5307ca89a9de7856d5b0bc53e9c1a2ab7 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

@@ -200,7 +200,7 @@ class MajorGCWrapperVisitor : public v8::PersistentHandleVisitor {

m_isolate->SetObjectGroupId(

*value, v8::UniqueId(reinterpret_cast<intptr_t>(root)));

if (m_constructRetainedObjectInfos)

- m_groupsWhichNeedRetainerInfo.append(root);

+ m_groupsWhichNeedRetainerInfo.push_back(root);

} else if (classId == WrapperTypeInfo::ObjectClassId) {

if (!RuntimeEnabledFeatures::traceWrappablesEnabled()) {

type->visitDOMWrapper(m_isolate, toScriptWrappable(wrapper),