third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp - Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N] (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

index c28a5b0c0ba0728cc7eebbecfe557f47ef6d9ba3..0442037da0631ca09164e145afc086535cf88c4c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp

@@ -170,7 +170,7 @@ TEST(ScriptWrappableVisitorTest, OilpanClearsHeadersWhenObjectDied) {

ScriptWrappableVisitor* visitor =

V8PerIsolateData::from(scope.isolate())->scriptWrappableVisitor();

auto header = HeapObjectHeader::fromPayload(object);

- visitor->getHeadersToUnmark()->append(header);

+ visitor->getHeadersToUnmark()->push_back(header);

preciselyCollectGarbage();