third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp - Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp

Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N] (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp

index 5fcbae59b71792bbaf1368cd91c1ae45a8a1dfdc..56a922d919709a087e40c99e0d006a5f97ea47f6 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp

@@ -172,7 +172,7 @@ v8::Local<v8::Object> V8PerContextData::prototypeForType(

void V8PerContextData::addCustomElementBinding(

std::unique_ptr<V0CustomElementBinding> binding) {

- m_customElementBindings.append(std::move(binding));

+ m_customElementBindings.push_back(std::move(binding));

}

v8::Local<v8::Value> V8PerContextData::compiledPrivateScript(String className) {