Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp

Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N] (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp
index 7813369269b0692ec9eb1789f009db3a92d90dc0..e7947391611ea51ce7a77c970942238a97e08a1c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp
@@ -312,10 +312,10 @@ TEST(ScriptPromiseTest, allWithResolvedPromises) {
ScriptValue onFulfilled, onRejected;
Vector<ScriptPromise> promises;
- promises.append(ScriptPromise::cast(scope.getScriptState(),
- v8String(scope.isolate(), "hello")));
- promises.append(ScriptPromise::cast(scope.getScriptState(),
- v8String(scope.isolate(), "world")));
+ promises.push_back(ScriptPromise::cast(scope.getScriptState(),
+ v8String(scope.isolate(), "hello")));
+ promises.push_back(ScriptPromise::cast(scope.getScriptState(),
+ v8String(scope.isolate(), "world")));
ScriptPromise promise = ScriptPromise::all(scope.getScriptState(), promises);
ASSERT_FALSE(promise.isEmpty());
@@ -341,10 +341,10 @@ TEST(ScriptPromiseTest, allWithRejectedPromise) {
ScriptValue onFulfilled, onRejected;
Vector<ScriptPromise> promises;
- promises.append(ScriptPromise::cast(scope.getScriptState(),
- v8String(scope.isolate(), "hello")));
- promises.append(ScriptPromise::reject(scope.getScriptState(),
- v8String(scope.isolate(), "world")));
+ promises.push_back(ScriptPromise::cast(scope.getScriptState(),
+ v8String(scope.isolate(), "hello")));
+ promises.push_back(ScriptPromise::reject(scope.getScriptState(),
+ v8String(scope.isolate(), "world")));
ScriptPromise promise = ScriptPromise::all(scope.getScriptState(), promises);
ASSERT_FALSE(promise.isEmpty());

Powered by Google App Engine
This is Rietveld 408576698