Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N] (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 for (uint32_t i = 0; i < propertyNames->Length(); ++i) { 189 for (uint32_t i = 0; i < propertyNames->Length(); ++i) {
190 v8::Local<v8::String> key; 190 v8::Local<v8::String> key;
191 if (!getStringValueInArray(v8Context(), propertyNames, i).ToLocal(&key)) { 191 if (!getStringValueInArray(v8Context(), propertyNames, i).ToLocal(&key)) {
192 exceptionState.rethrowV8Exception(tryCatch.Exception()); 192 exceptionState.rethrowV8Exception(tryCatch.Exception());
193 return Vector<String>(); 193 return Vector<String>();
194 } 194 }
195 V8StringResource<> stringKey(key); 195 V8StringResource<> stringKey(key);
196 if (!stringKey.prepare(isolate(), exceptionState)) 196 if (!stringKey.prepare(isolate(), exceptionState))
197 return Vector<String>(); 197 return Vector<String>();
198 198
199 names.append(stringKey); 199 names.push_back(stringKey);
200 } 200 }
201 201
202 return names; 202 return names;
203 } 203 }
204 204
205 } // namespace blink 205 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698