third_party/WebKit/Source/bindings/core/v8/V8PersistentValueVector.h - Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PersistentValueVector.h

Issue 2554693003: Migrate WTF::Vector::append() to ::push_back() [part 1 of N] (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8PersistentValueVector.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PersistentValueVector.h b/third_party/WebKit/Source/bindings/core/v8/V8PersistentValueVector.h

index 45058f558a284d33a9afb4a37d85dd870ef67b6f..d5f37c88d52bb5b3dbe6363b9f754101d173e9cc 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PersistentValueVector.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PersistentValueVector.h

@@ -44,7 +44,7 @@ class WTFVectorPersistentValueVectorTraits {

public:

typedef Vector<v8::PersistentContainerValue> Impl;

static void Append(Impl* impl, v8::PersistentContainerValue value) {

- impl->append(value);

+ impl->push_back(value);

}

static bool IsEmpty(const Impl* impl) { return impl->isEmpty(); }

static size_t Size(const Impl* impl) { return impl->size(); }