Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 24980006: ash: Remove old lock animation implementation. (Closed)

Created:
7 years, 2 months ago by Daniel Erat
Modified:
7 years, 2 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

ash: Remove old lock animation implementation. This deletes the SessionStateControllerImpl class (formerly used when the --ash-disable-new-lock-animations flag, which I'm also removing, was set) and moves LockStateControllerImpl2 into LockStateController (which was formerly an interface). BUG=294310 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226298

Patch Set 1 #

Patch Set 2 : remove StartShutdownAnimationImpl() and duplicate include #

Total comments: 1

Patch Set 3 : merge #

Patch Set 4 : merge again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+862 lines, -3267 lines) Patch
M ash/ash.gyp View 1 2 3 chunks +1 line, -6 lines 0 comments Download
M ash/ash_switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M ash/shell.cc View 1 2 3 chunks +1 line, -6 lines 0 comments Download
M ash/wm/lock_state_controller.h View 1 4 chunks +202 lines, -20 lines 0 comments Download
M ash/wm/lock_state_controller.cc View 1 2 2 chunks +610 lines, -1 line 0 comments Download
D ash/wm/lock_state_controller_impl2.h View 1 chunk +0 lines, -263 lines 0 comments Download
D ash/wm/lock_state_controller_impl2.cc View 1 2 1 chunk +0 lines, -643 lines 0 comments Download
D ash/wm/lock_state_controller_impl2_unittest.cc View 1 chunk +0 lines, -1070 lines 0 comments Download
A + ash/wm/lock_state_controller_unittest.cc View 26 chunks +32 lines, -38 lines 0 comments Download
D ash/wm/power_button_controller_unittest.cc View 1 chunk +0 lines, -637 lines 0 comments Download
D ash/wm/session_state_controller_impl.h View 1 chunk +0 lines, -195 lines 0 comments Download
D ash/wm/session_state_controller_impl.cc View 1 2 1 chunk +0 lines, -341 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 chunk +8 lines, -13 lines 0 comments Download
M chrome/browser/resources/chromeos/login/header_bar.css View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Daniel Erat
https://codereview.chromium.org/24980006/diff/3001/ash/wm/power_button_controller_unittest.cc File ash/wm/power_button_controller_unittest.cc (left): https://codereview.chromium.org/24980006/diff/3001/ash/wm/power_button_controller_unittest.cc#oldcode1 ash/wm/power_button_controller_unittest.cc:1: // Copyright (c) 2012 The Chromium Authors. All rights ...
7 years, 2 months ago (2013-09-27 23:20:17 UTC) #1
Nikita (slow)
lgtm See also https://code.google.com/p/chromium/issues/detail?id=162645 that is about re-enabling test coverage for new animations which appears ...
7 years, 2 months ago (2013-09-30 09:56:22 UTC) #2
Denis Kuznetsov (DE-MUC)
lgtm
7 years, 2 months ago (2013-09-30 12:45:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/24980006/11001
7 years, 2 months ago (2013-09-30 15:59:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/24980006/34001
7 years, 2 months ago (2013-09-30 20:15:51 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=173545
7 years, 2 months ago (2013-10-01 04:22:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/24980006/34001
7 years, 2 months ago (2013-10-01 12:40:53 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-01 21:08:36 UTC) #8
Message was sent while issue was closed.
Change committed as 226298

Powered by Google App Engine
This is Rietveld 408576698