|
Change behaivor to decide whether a search engine should be shown in the default list
1. Delete show_in_default_list field in template_url_data.
2. New rule checks whether a search engine is prepopulated or created by
policy or now selected as default to decide whether it should appears in the
default search setting list. The search engine should also support search
term replacement if it is in that list.
3. Search engines parsed from Firefox by default will not appears in the
default list.
BUG= 348360
Committed: https://crrev.com/cf06dd01d2516e1509acd1e99b20ccff09b8c19a
Cr-Commit-Position: refs/heads/master@{#433151}
Total comments: 37
Total comments: 16
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+283 lines, -351 lines) |
Patch |
|
M |
chrome/browser/android/locale/special_locale_handler.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/importer/in_process_importer_bridge.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/importer/profile_writer.cc
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/search_engines/template_url_parser_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/search_engines/template_url_service_sync_unittest.cc
|
View
|
|
4 chunks |
+4 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/search_engines/template_url_service_unittest.cc
|
View
|
1
2
|
22 chunks |
+28 lines, -25 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/search_engines/template_url_table_model.cc
|
View
|
1
|
1 chunk |
+5 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/browser_options_handler.cc
|
View
|
1
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
components/search_engines/default_search_manager.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
components/search_engines/default_search_manager_unittest.cc
|
View
|
|
3 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/search_engines/default_search_pref_migration.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
components/search_engines/keyword_table.h
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/search_engines/keyword_table.cc
|
View
|
1
2
|
9 chunks |
+81 lines, -36 lines |
0 comments
|
Download
|
|
M |
components/search_engines/keyword_table_unittest.cc
|
View
|
|
3 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
|
M |
components/search_engines/template_url.h
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
|
M |
components/search_engines/template_url.cc
|
View
|
|
2 chunks |
+0 lines, -7 lines |
0 comments
|
Download
|
|
M |
components/search_engines/template_url_data.h
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
components/search_engines/template_url_data.cc
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
components/search_engines/template_url_fetcher.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
components/search_engines/template_url_parser.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
components/search_engines/template_url_parser.cc
|
View
|
|
5 chunks |
+3 lines, -9 lines |
0 comments
|
Download
|
|
M |
components/search_engines/template_url_prepopulate_data.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
components/search_engines/template_url_service.h
|
View
|
1
2
|
1 chunk |
+7 lines, -0 lines |
0 comments
|
Download
|
|
M |
components/search_engines/template_url_service.cc
|
View
|
1
2
|
6 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
components/search_engines/template_url_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
components/sync/protocol/proto_visitors.h
|
View
|
1
2
|
35 chunks |
+91 lines, -202 lines |
0 comments
|
Download
|
|
M |
components/sync/protocol/search_engine_specifics.proto
|
View
|
1
2
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
A + |
components/test/data/web_database/version_67.sql
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/webdata/common/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
components/webdata/common/web_database.cc
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/webdata/common/web_database_migration_unittest.cc
|
View
|
|
2 chunks |
+33 lines, -1 line |
0 comments
|
Download
|
Dependent Patchsets:
Total messages: 38 (21 generated)
|