Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: components/search_engines/template_url_service.cc

Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list (Closed)
Patch Set: Update based on Peter and Nicolas's comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/template_url_service.cc
diff --git a/components/search_engines/template_url_service.cc b/components/search_engines/template_url_service.cc
index 22e2db0b3fa16c320df785db633dc5f7ab4c8bfa..5efc50df69b55bdbf1e17f31fa4201d59d861d2d 100644
--- a/components/search_engines/template_url_service.cc
+++ b/components/search_engines/template_url_service.cc
@@ -395,6 +395,12 @@ bool TemplateURLService::CanAddAutogeneratedKeyword(
CanAddAutogeneratedKeywordForHost(url.host());
}
+bool TemplateURLService::ShowInDefaultList(const TemplateURL* t_url) {
+ return (t_url == default_search_provider_ || t_url->prepopulate_id() > 0 ||
+ t_url->created_by_policy()) &&
+ t_url->SupportsReplacement(search_terms_data());
+}
+
void TemplateURLService::AddMatchingKeywords(
const base::string16& prefix,
bool supports_replacement_only,
@@ -477,8 +483,6 @@ TemplateURL* TemplateURLService::AddExtensionControlledTURL(
DCHECK_EQ(kInvalidTemplateURLID, template_url->id());
DCHECK(info);
DCHECK_NE(TemplateURL::NORMAL, template_url->type());
- DCHECK_EQ(info->wants_to_be_default_engine,
- template_url->show_in_default_list());
DCHECK(
!FindTemplateURLForExtension(info->extension_id, template_url->type()));
template_url->extension_info_.swap(info);
@@ -1244,7 +1248,6 @@ syncer::SyncData TemplateURLService::CreateSyncDataFromTemplateURL(
se_specifics->set_date_created(turl.date_created().ToInternalValue());
se_specifics->set_input_encodings(
base::JoinString(turl.input_encodings(), ";"));
- se_specifics->set_show_in_default_list(turl.show_in_default_list());
se_specifics->set_suggestions_url(turl.suggestions_url());
se_specifics->set_prepopulate_id(turl.prepopulate_id());
se_specifics->set_instant_url(turl.instant_url());
@@ -1324,7 +1327,6 @@ TemplateURLService::CreateTemplateURLFromTemplateURLAndSyncData(
data.instant_url_post_params = specifics.instant_url_post_params();
data.image_url_post_params = specifics.image_url_post_params();
data.favicon_url = GURL(specifics.favicon_url());
- data.show_in_default_list = specifics.show_in_default_list();
data.safe_for_autoreplace = specifics.safe_for_autoreplace();
data.input_encodings = base::SplitString(
specifics.input_encodings(), ";",
@@ -1641,8 +1643,7 @@ bool TemplateURLService::CanAddAutogeneratedKeywordForHost(
}
bool TemplateURLService::CanReplace(const TemplateURL* t_url) {
- return (t_url != default_search_provider_ && !t_url->show_in_default_list() &&
- t_url->safe_for_autoreplace());
+ return !ShowInDefaultList(t_url) && t_url->safe_for_autoreplace();
}
TemplateURL* TemplateURLService::FindNonExtensionTemplateURLForKeyword(
@@ -1967,7 +1968,6 @@ bool TemplateURLService::ApplyDefaultSearchChangeNoMetrics(
FindPrepopulatedTemplateURL(data->prepopulate_id);
}
TemplateURLData new_data(*data);
- new_data.show_in_default_list = true;
if (default_search_provider_) {
UpdateNoNotify(default_search_provider_, TemplateURL(new_data));
} else {
« no previous file with comments | « components/search_engines/template_url_service.h ('k') | components/search_engines/template_url_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698