Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: components/search_engines/template_url.cc

Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list (Closed)
Patch Set: Update based on Peter and Nicolas's comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/search_engines/template_url.h ('k') | components/search_engines/template_url_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/search_engines/template_url.cc
diff --git a/components/search_engines/template_url.cc b/components/search_engines/template_url.cc
index 8902965292274238a3d256244bb78ee6ad0e2e21..1291fbd1ba88f59401269ad60be4f5d8a675ffd8 100644
--- a/components/search_engines/template_url.cc
+++ b/components/search_engines/template_url.cc
@@ -1253,7 +1253,6 @@ bool TemplateURL::MatchesData(const TemplateURL* t_url,
(t_url->image_url_post_params() == data->image_url_post_params) &&
(t_url->favicon_url() == data->favicon_url) &&
(t_url->safe_for_autoreplace() == data->safe_for_autoreplace) &&
- (t_url->show_in_default_list() == data->show_in_default_list) &&
(t_url->input_encodings() == data->input_encodings) &&
(t_url->alternate_urls() == data->alternate_urls) &&
(t_url->search_terms_replacement_key() ==
@@ -1266,12 +1265,6 @@ base::string16 TemplateURL::AdjustedShortNameForLocaleDirection() const {
return bidi_safe_short_name;
}
-bool TemplateURL::ShowInDefaultList(
- const SearchTermsData& search_terms_data) const {
- return data_.show_in_default_list &&
- url_ref_->SupportsReplacement(search_terms_data);
-}
-
bool TemplateURL::SupportsReplacement(
const SearchTermsData& search_terms_data) const {
return url_ref_->SupportsReplacement(search_terms_data);
« no previous file with comments | « components/search_engines/template_url.h ('k') | components/search_engines/template_url_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698