Change behaivor to decide whether a search engine should be shown in the default list

chrome/browser/ui/search_engines/template_url_table_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/search_engines/template_url_table_model.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/i18n/rtl.h"
@@ skipping 125 matching lines @@
 void TemplateURLTableModel::Reload() {
   entries_.clear();
 
   TemplateURLService::TemplateURLVector urls =
       template_url_service_->GetTemplateURLs();
 
   std::vector<std::unique_ptr<ModelEntry>> default_entries, other_entries,
       extension_entries;
   // Keywords that can be made the default first.
   for (auto* template_url : urls) {
-    // NOTE: we don't use ShowInDefaultList here to avoid items bouncing around
-    // the lists while editing.
-    if (template_url->show_in_default_list())
+    if (template_url_service_->ShowInDefaultList(template_url))

[Peter Kasting, 2016/11/10 06:41:06]

Nit: While here: This code is out of compliance with the style guide due to
missing {}.  How about this fix:

    auto entry = base::MakeUnique<ModelEntry>(this, template_url);
    if (template_url_service_->ShowInDefaultList(template_url))
      default_entries.push_back(std::move(entry));
    else if (template_url->type() == TemplateURL::OMNIBOX_API_EXTENSION)
      extension_entries.push_back(std::move(entry));
    else
      other_entries.push_back(std::move(entry));

[ltian, 2016/11/11 03:52:13]

Done.

       default_entries.push_back(
           base::MakeUnique<ModelEntry>(this, template_url));
     else if (template_url->type() == TemplateURL::OMNIBOX_API_EXTENSION)
       extension_entries.push_back(
           base::MakeUnique<ModelEntry>(this, template_url));
     else
       other_entries.push_back(base::MakeUnique<ModelEntry>(this, template_url));
   }
 
   last_search_engine_index_ = static_cast<int>(default_entries.size());
@@ skipping 227 matching lines @@
 }
 
 void TemplateURLTableModel::AddEntry(int index,
                                      std::unique_ptr<ModelEntry> entry) {
   entries_.insert(entries_.begin() + index, std::move(entry));
   if (index <= last_other_engine_index_)
     ++last_other_engine_index_;
   if (observer_)
     observer_->OnItemsAdded(index, 1);
 }