Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list (Closed)
Patch Set: Update based on Peter and Nicolas's comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index 277d5d35a6445ad7a22814177d13af8c5990eef2..cfe68e9e8889ea3ddfae430f37b064e2d2711190 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -1244,15 +1244,15 @@ void BrowserOptionsHandler::OnTemplateURLServiceChanged() {
TemplateURLService::TemplateURLVector model_urls(
template_url_service_->GetTemplateURLs());
for (size_t i = 0; i < model_urls.size(); ++i) {
- if (!model_urls[i]->ShowInDefaultList(
- template_url_service_->search_terms_data()))
+ TemplateURL* t_url = model_urls[i];
+ if (!template_url_service_->ShowInDefaultList(t_url))
continue;
std::unique_ptr<base::DictionaryValue> entry(new base::DictionaryValue());
- entry->SetString("name", model_urls[i]->short_name());
+ entry->SetString("name", t_url->short_name());
entry->SetInteger("index", i);
search_engines.Append(std::move(entry));
- if (model_urls[i] == default_url)
+ if (t_url == default_url)
default_index = i;
}
« no previous file with comments | « chrome/browser/ui/search_engines/template_url_table_model.cc ('k') | components/search_engines/default_search_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698