components/search_engines/template_url_fetcher.cc - Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/template_url_fetcher.cc

Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list (Closed)

Patch Set: Update based on Peter and Nicolas's comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/search_engines/template_url_fetcher.cc

diff --git a/components/search_engines/template_url_fetcher.cc b/components/search_engines/template_url_fetcher.cc

index 6274531e2c57d2239eb685dba612be4f8f5b6243..cf972d0eeb915643151d183a8757c22f6fabeb78 100644

--- a/components/search_engines/template_url_fetcher.cc

+++ b/components/search_engines/template_url_fetcher.cc

@@ -112,7 +112,7 @@ void TemplateURLFetcher::RequestDelegate::OnURLFetchComplete(

}

template_url_ = TemplateURLParser::Parse(

- fetcher_->template_url_service_->search_terms_data(), false, data.data(),

+ fetcher_->template_url_service_->search_terms_data(), data.data(),

data.length(), nullptr);

if (!template_url_.get() ||

!template_url_->url_ref().SupportsReplacement(