Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Side by Side Diff: components/webdata/common/web_database_migration_unittest.cc

Issue 2487633003: Change behaivor to decide whether a search engine should be shown in the default list (Closed)
Patch Set: Update based on Peter and Nicolas's comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/webdata/common/web_database.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/guid.h" 9 #include "base/guid.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 // > .output version_nn.sql 123 // > .output version_nn.sql
124 // > .dump 124 // > .dump
125 void LoadDatabase(const base::FilePath::StringType& file); 125 void LoadDatabase(const base::FilePath::StringType& file);
126 126
127 private: 127 private:
128 base::ScopedTempDir temp_dir_; 128 base::ScopedTempDir temp_dir_;
129 129
130 DISALLOW_COPY_AND_ASSIGN(WebDatabaseMigrationTest); 130 DISALLOW_COPY_AND_ASSIGN(WebDatabaseMigrationTest);
131 }; 131 };
132 132
133 const int WebDatabaseMigrationTest::kCurrentTestedVersionNumber = 67; 133 const int WebDatabaseMigrationTest::kCurrentTestedVersionNumber = 68;
134 134
135 void WebDatabaseMigrationTest::LoadDatabase( 135 void WebDatabaseMigrationTest::LoadDatabase(
136 const base::FilePath::StringType& file) { 136 const base::FilePath::StringType& file) {
137 std::string contents; 137 std::string contents;
138 ASSERT_TRUE(GetWebDatabaseData(base::FilePath(file), &contents)); 138 ASSERT_TRUE(GetWebDatabaseData(base::FilePath(file), &contents));
139 139
140 sql::Connection connection; 140 sql::Connection connection;
141 ASSERT_TRUE(connection.Open(GetDatabasePath())); 141 ASSERT_TRUE(connection.Open(GetDatabasePath()));
142 ASSERT_TRUE(connection.Execute(contents.data())); 142 ASSERT_TRUE(connection.Execute(contents.data()));
143 } 143 }
(...skipping 918 matching lines...) Expand 10 before | Expand all | Expand 10 after
1062 EXPECT_TRUE(connection.DoesColumnExist("masked_credit_cards", 1062 EXPECT_TRUE(connection.DoesColumnExist("masked_credit_cards",
1063 "billing_address_id")); 1063 "billing_address_id"));
1064 1064
1065 sql::Statement read_masked(connection.GetUniqueStatement( 1065 sql::Statement read_masked(connection.GetUniqueStatement(
1066 "SELECT name_on_card, billing_address_id FROM masked_credit_cards")); 1066 "SELECT name_on_card, billing_address_id FROM masked_credit_cards"));
1067 ASSERT_TRUE(read_masked.Step()); 1067 ASSERT_TRUE(read_masked.Step());
1068 EXPECT_EQ("Alice", read_masked.ColumnString(0)); 1068 EXPECT_EQ("Alice", read_masked.ColumnString(0));
1069 EXPECT_TRUE(read_masked.ColumnString(1).empty()); 1069 EXPECT_TRUE(read_masked.ColumnString(1).empty());
1070 } 1070 }
1071 } 1071 }
1072
1073 // Tests delete show_in_default_list column in keywords table.
1074 TEST_F(WebDatabaseMigrationTest, MigrateVersion67ToCurrent) {
1075 ASSERT_NO_FATAL_FAILURE(LoadDatabase(FILE_PATH_LITERAL("version_67.sql")));
1076
1077 // Verify pre-conditions.
1078 {
1079 sql::Connection connection;
1080 ASSERT_TRUE(connection.Open(GetDatabasePath()));
1081 ASSERT_TRUE(sql::MetaTable::DoesTableExist(&connection));
1082
1083 sql::MetaTable meta_table;
1084 ASSERT_TRUE(meta_table.Init(&connection, 67, 67));
1085
1086 EXPECT_TRUE(connection.DoesColumnExist("keywords", "show_in_default_list"));
1087 }
1088
1089 DoMigration();
1090
1091 // Verify post-conditions.
1092 {
1093 sql::Connection connection;
1094 ASSERT_TRUE(connection.Open(GetDatabasePath()));
1095 ASSERT_TRUE(sql::MetaTable::DoesTableExist(&connection));
1096
1097 // Check version.
1098 EXPECT_EQ(kCurrentTestedVersionNumber, VersionFromConnection(&connection));
1099
1100 EXPECT_FALSE(
1101 connection.DoesColumnExist("keywords", "show_in_default_list"));
1102 }
1103 }
OLDNEW
« no previous file with comments | « components/webdata/common/web_database.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698